Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SANS2D: Named Aperture & Guide Positions #4573

Closed
kjwoodsISIS opened this issue Jul 19, 2019 · 6 comments
Closed

SANS2D: Named Aperture & Guide Positions #4573

kjwoodsISIS opened this issue Jul 19, 2019 · 6 comments
Assignees
Labels
2 fixed for release Required for next release rework
Projects

Comments

@kjwoodsISIS
Copy link
Contributor

kjwoodsISIS commented Jul 19, 2019

As a SANS2D scientist, I want IBEX to provide me with a set of named positions for all moveable waveguides & apertures on SANS2D, so that I can easily position all of them in a single operation.

Acceptance Criteria

  1. The IBEX GUI provides a control to allow me to select a named position
    • the position selector could be a drop-down box control
    • the position selector appears only on the "user" tab of the IBEX GUI.
  2. IBEX allows me to select from the following named positions:
    • 4m_20_8mm
    • 4m_20_12mm
    • 4m_30x20_12mm
    • 6m_20_8mm
    • 6m_16_8mm
    • 6m_GISANS
    • 8m_20_8mm
    • 8m_GISANS
    • 12m_20_8mm
    • 12m_GISANS
  3. Motion is disabled/enabled if the PLC inhibit signal is on/off.
  4. On selecting a named position,
    1. if motion is enabled, IBEX moves all of the moveable waveguides & apertures to their corresponding positions (defined in a configuration file).
    2. if motion is disabled, IBEX does not move any aperture or waveguide.
      • the position selector should be greyed out when motion is inhibited
      • genie_python should report that it cannot move the relevant axis.
  5. I can move all 5 moveable waveguides & apertures to named positions via the IBEX GUI
  6. I can move all 5 moveable waveguides & apertures to named positions via genie_python
  7. IBEX provides the same level of functionality as the existing LabVIEW VIs

Notes

  1. This ticket is a sub-ticket of SANS2D: Control of Aperture & Guides (EPIC) #4568.
  2. Each moveable waveguide and each moveable aperture has its own defined positions. When the user selects a named position, all of the moveable waveguides and all of the moveable apertures should move (together) to their respective named positions.
  3. The position of each moveable aperture is controlled by a Galil controller & stepper motor.
    • The apertures are heavy - there is a risk that they can fall under their own gravity. Therefore, when movement of the apertures is complete, the motors must remain energised (they require power to hold the load).
  4. The position of each moveable waveguide is controlled by a Galil controller. The waveguides are heavy, so they are actually moved by Baldor drives. The Baldor drives are slaved to the Galils. For the avoidance of doubt, from the perspective of IBEX, the motion is controlled solely by Galils; IBEX does not (and should not) control the Baldor drives directly.
  5. There are schematic diagrams showing the operation of the SANS2D apertures and waveguides.
  6. There are schematic diagrams showing the how the SANS2D apertures and waveguides User OPI and Advanced OPI could look.
  7. The LabVIEW VI for the SANS2D apertures and waveguides is located at: C:\LabVIEW Modules\Instruments\SANS2D\Sans2d Waveguide (for more details see the S2d - Waveguide Front Panel.vi in the file Sans2d - Waveguide Motion.llb)
  8. The LabVIEW configuration file for the SANS2D apertures and waveguides is located at: C:\LabVIEW Modules\Instruments\SANS2D\S2D Front End Positions.ini.
  9. Check the paragraphs labelled S1-S5 and G1-G5 in the Beam_line_descriptors document.
@kjwoodsISIS kjwoodsISIS added this to To do in SANS2D Apr 3, 2020
@DominicOram DominicOram self-assigned this Jul 13, 2020
@DominicOram DominicOram added in progress sub-ticket Subticket that can have zero points labels Jul 13, 2020
@DominicOram DominicOram added this to In Progress in IBEX Project Board Jul 13, 2020
@DominicOram DominicOram added this to the SPRINT_2020_06_25 milestone Jul 13, 2020
@JamesKingWork JamesKingWork added 13 and removed sub-ticket Subticket that can have zero points labels Jul 23, 2020
@John-Holt-Tessella John-Holt-Tessella moved this from To do to In Progress in SANS2D Jul 24, 2020
@DominicOram
Copy link
Contributor

DominicOram commented Aug 14, 2020

In discussion with @John-Holt-Tessella, @KathrynBaker and @Tom-Willemsen it was decided that removing bare motor support from the motionsetpoints should be done as part of this ticket

@John-Holt-Tessella
Copy link
Contributor

Can we check that the decision is recorded correctly in decision log https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Decision-Log

@DominicOram
Copy link
Contributor

Thanks @John-Holt-Tessella

@DominicOram
Copy link
Contributor

Once merged confirm it hasn't broken anything in #5719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2 fixed for release Required for next release rework
Projects
SANS2D
  
Done
Development

No branches or pull requests

4 participants