-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket 4573: SANS2D, Named aperture and guide positions #14
Merged
JamesKingWork
merged 40 commits into
master
from
Ticket4573_named_aperture_and_guide_positions
Oct 28, 2020
Merged
Ticket 4573: SANS2D, Named aperture and guide positions #14
JamesKingWork
merged 40 commits into
master
from
Ticket4573_named_aperture_and_guide_positions
Oct 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2020
Merged
JamesKingWork
previously requested changes
Aug 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments, any questions let me know
JamesKingWork
approved these changes
Oct 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, very tidy
JamesKingWork
deleted the
Ticket4573_named_aperture_and_guide_positions
branch
October 28, 2020 17:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See ISISComputingGroup/IBEX#4573.
In doing this support was also removed for non-axis motors, see https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Decision-Log
Also fixes (close or comment on these as appropriate):
To test:
make runtests
in the top directory (you will need Google test: use new EPICS mechanism IBEX#5513)