Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket 4573: SANS2D, Named aperture and guide positions #14

Merged
merged 40 commits into from
Oct 28, 2020

Conversation

DominicOram
Copy link
Contributor

@DominicOram DominicOram commented Aug 17, 2020

See ISISComputingGroup/IBEX#4573.

In doing this support was also removed for non-axis motors, see https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Decision-Log

Also fixes (close or comment on these as appropriate):

To test:

Copy link
Contributor

@JamesKingWork JamesKingWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments, any questions let me know

Makefile Outdated Show resolved Hide resolved
motionSetPointsApp/Db/motionSetPoints10Axis.substitutions Outdated Show resolved Hide resolved
motionSetPointsApp/src/tests/testSetPoint.cc Outdated Show resolved Hide resolved
motionSetPointsApp/src/tests/testSetPoint.cc Outdated Show resolved Hide resolved
motionSetPointsApp/src/tests/testSetPoint.cc Outdated Show resolved Hide resolved
motionSetPointsApp/src/tests/testSetPoint.cc Outdated Show resolved Hide resolved
motionSetPointsApp/src/setPoint.hpp Show resolved Hide resolved
@JamesKingWork JamesKingWork dismissed their stale review October 28, 2020 15:57

Changes addressed

Copy link
Contributor

@JamesKingWork JamesKingWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, very tidy

@JamesKingWork JamesKingWork merged commit 0b2a43e into master Oct 28, 2020
@JamesKingWork JamesKingWork deleted the Ticket4573_named_aperture_and_guide_positions branch October 28, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants