Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMAT: Sample Stack naming and ordering is inconsistent #6632

Closed
DominicOram opened this issue Jul 8, 2021 · 9 comments
Closed

IMAT: Sample Stack naming and ordering is inconsistent #6632

DominicOram opened this issue Jul 8, 2021 · 9 comments
Assignees

Comments

@DominicOram
Copy link
Contributor

DominicOram commented Jul 8, 2021

As an IS on IMAT I would like the naming and ordering of my sample stack axes to be consistent. Currently the naming on the table of motors does not match that on the synoptic, which also does not match that on the Sample Stack OPI. The ordering of items on the synoptic and on the OPI are also different.

Acceptance Criteria

  • The axes are in the same order in Synopitic view and in OPI
  • The axes have same name in ToM, Synoptic and Sample Stack OPI
  • Axes have been renamed in accordance with presentation table
@rerpha
Copy link
Contributor

rerpha commented Jul 21, 2021

related to #6424 ? can the same logic be applied?

@DominicOram
Copy link
Contributor Author

DominicOram commented Jul 21, 2021

No, the other ticket is the generic SANS sample changer, this is a sample stack, subtly different. A sample changer is a bit of kit allowing you to select many samples, the sample stack is a place to put one sample where you can rotate it, translate it etc. But good question!

@rerpha
Copy link
Contributor

rerpha commented Jul 21, 2021

Sorry, was thinking more for the ordering side of things

@DominicOram
Copy link
Contributor Author

The ordering issue from #6424 comes from reading the xml that the sample changer code uses. The sample stack doesn't have any configuration files like that, it's just some dumb axes, we would just need to rearrange things on the OPI

@Adam-Szw Adam-Szw self-assigned this Aug 9, 2021
@Adam-Szw Adam-Szw added this to the SPRINT_2021_07_22 milestone Aug 9, 2021
@Adam-Szw Adam-Szw added the 0 label Aug 9, 2021
@Adam-Szw
Copy link
Contributor

@Adam-Szw
Copy link
Contributor

Release notes PR #6711

@DominicOram
Copy link
Contributor Author

DominicOram commented Aug 11, 2021

I haven't checked what you've done @Adam-Szw but to add some more requirements for the reviewer:

@Adam-Szw
Copy link
Contributor

I wasnt aware of these and didnt order it according to slide. Gonna do it now

@Adam-Szw
Copy link
Contributor

Adam-Szw commented Aug 11, 2021

Changes Branch: https://control-svcs.isis.cclrc.ac.uk/git/?p=instconfigs/inst.git;a=shortlog;h=refs/heads/NDXIMAT_Ticket_6632_Updated

Names in Table of Motors can only be changed when IMAT is online again

There is a bit of rubbish like sample.txt but this file should be overwritten when gui runs on imat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants