-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMAT: Sample Stack naming and ordering is inconsistent #6632
Comments
related to #6424 ? can the same logic be applied? |
No, the other ticket is the generic SANS sample changer, this is a sample stack, subtly different. A sample changer is a bit of kit allowing you to select many samples, the sample stack is a place to put one sample where you can rotate it, translate it etc. But good question! |
Sorry, was thinking more for the ordering side of things |
The ordering issue from #6424 comes from reading the xml that the sample changer code uses. The sample stack doesn't have any configuration files like that, it's just some dumb axes, we would just need to rearrange things on the OPI |
Release notes PR #6711 |
I haven't checked what you've done @Adam-Szw but to add some more requirements for the reviewer:
|
I wasnt aware of these and didnt order it according to slide. Gonna do it now |
Changes Branch: https://control-svcs.isis.cclrc.ac.uk/git/?p=instconfigs/inst.git;a=shortlog;h=refs/heads/NDXIMAT_Ticket_6632_Updated Names in Table of Motors can only be changed when IMAT is online again There is a bit of rubbish like sample.txt but this file should be overwritten when gui runs on imat |
As an IS on IMAT I would like the naming and ordering of my sample stack axes to be consistent. Currently the naming on the table of motors does not match that on the synoptic, which also does not match that on the Sample Stack OPI. The ordering of items on the synoptic and on the OPI are also different.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: