Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed breaking change for checkstyle 8.42 #1346

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DominicOram
Copy link
Contributor

Description of work

Fixed the config to work for the latest version of checkstyle (checkstyle/checkstyle#4465)

To test:

  • With the latest version of checkstyle run the checkstyle checks and confirm they run

Once this is merged everyone will need to update checkstyle, once merged please put the instructions on dev-changes (https://checkstyle.org/eclipse-cs/index.html#!/)


Code Review

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?
  • Is there associated PR for the release notes?

Final Steps

Copy link
Contributor

@JamesKingWork JamesKingWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks the build as accessModifiers is not available for the Checkstyle version we use in the build. I'm not quite sure how to fix that, but I can't approve it as is

@DominicOram
Copy link
Contributor Author

I think we should move the build version forward

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants