Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket 8067 switch instruments #1669

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

danielmaclaren
Copy link
Contributor

@danielmaclaren danielmaclaren commented Jan 8, 2024

Description of work

The UI and GUI seems to be out of sync, code was added to bring them back inline after switching instruments.

Ticket

Link to Ticket

Acceptance criteria

See Ticket

Unit tests

Squish test added - tst_make_change_without_applying_and_switch_instrument


Code Review

Final Steps

@Chsudeepta
Copy link
Contributor

If I make a change in the Experiment Setup Panel for Local --> Apply Change button is highlighted as expected.
With out clicking on the apply change, if I switch instrument then Apply Change button is no more highlighted. This is as expected as per the change required. However the changed (but unsaved) value is lost once I switched back to localhost.

Discussed with Daniel and it is agreed that this isn't an issue as retaining local unapplied changes is only relevant while we are within the context of an instrument and switching instruments takes us to a different context.

@Chsudeepta Chsudeepta self-requested a review January 9, 2024 16:25
@Chsudeepta
Copy link
Contributor

This looks ok. Please feel free to delete the branch once you think it is safe.

@Chsudeepta Chsudeepta closed this Jan 10, 2024
@Chsudeepta Chsudeepta reopened this Jan 10, 2024
@Chsudeepta Chsudeepta closed this Jan 10, 2024
@Chsudeepta Chsudeepta self-assigned this Jan 10, 2024
@Chsudeepta Chsudeepta reopened this Jan 10, 2024
@Chsudeepta
Copy link
Contributor

Re-opened this as there are conflicts. Please check the script_definition. It may not be needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IBEX GUI: 'Apply Changes' button indicates changes have been made when switching instruments
2 participants