Ticket 2421: Fixed bug in setting run control from GUI

[DominicOram]

Description of work

This relates to ISISComputingGroup/IBEX#2421

The underlying reason for the problem was that PVs were created, then immediately written to without having time to connect. The problem was highlighted by ISISComputingGroup/IBEX#2298.

To test

• Create a config with some run controlled blocks

In the run control dialog confirm that:

• You can change low limits / high limits / enabled and send them to the server
• You can revert all run control back to that of the configuration

---

Code Review

• Is the code of an acceptable quality?
• Does the code conform to the coding standards? Is it well structured with small focussed classes/methods/functions?
• Are there unit tests in place? Are the unit tests small and test the a class in isolation?
• Are there automated system tests in place? Do they test a minimal set of functionality and leave the gui as close as possible to its original state?
• Has the manual system tests spreadsheet been updated?
  • Manual system tests for the functionality should be added if there are no automated tests
  • Manual system tests can be removed from the template if they are covered by suitable automated tests
• Did any existing system test break as a result of the current changes?
• Have the changes been documented in the release notes. If so, do they describe the changes appropriately?
• If an OPI has been modified, does it conform to the style guidelines? There is a script called check_opi_format.py to help with this.

Functional Tests

• Do changes function as described? Add comments below that describe the tests performed.
• How do the changes handle unexpected situations, e.g. bad input?
• Has developer documentation been updated if required?
• Have any new plugins been added to the appropriate feature.xml? You can check if this is needed by validating plugins as per method at https://github.com/ISISComputingGroup/ibex_developers_manual/wiki/Common-Eclipse-Issues

Final Steps

• Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

[DominicOram]

See system tests at ISISComputingGroup/ibex_system_tests#66

[samueljackson92]

• Tested with & without changes. Bug now seems to be fixed.
• Unit tests pass.
• System tests pass.

LGTM