Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add couette cell OPI #672

Merged
merged 4 commits into from
Apr 24, 2018
Merged

Add couette cell OPI #672

merged 4 commits into from
Apr 24, 2018

Conversation

Tom-Willemsen
Copy link
Contributor

@Tom-Willemsen Tom-Willemsen commented Apr 13, 2018 •
edited by John-Holt-Tessella

Description of work

OPI for couette cell

Ticket

ISISComputingGroup/IBEX#3105

Acceptance criteria

OPI is appropriate

Unit tests

None

System tests

None

Documentation

None

Code Review

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?
  • Have the changes been documented in the release notes?

Final Steps

  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

@Tom-Willemsen Tom-Willemsen changed the title Add skeleton couette cell OPI Add couette cell OPI Apr 13, 2018
@John-Holt-Tessella
Copy link
Contributor

John-Holt-Tessella commented Apr 23, 2018 •
edited by Tom-Willemsen

  • Think about moving Stop Move button into velocity depending on if this is how you stop the move
  • Think about making it three section top, middle and bottom. Would give a bit more room for sequence

@John-Holt-Tessella John-Holt-Tessella merged commit 55dad25 into master Apr 24, 2018
@John-Holt-Tessella John-Holt-Tessella deleted the Ticket3105_couette_cell branch April 24, 2018 16:00
@John-Holt-Tessella John-Holt-Tessella restored the Ticket3105_couette_cell branch May 2, 2018 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tom-Willemsen @John-Holt-Tessella