Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket3071 add ioc kicker #790

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Ticket3071 add ioc kicker #790

wants to merge 18 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 28, 2018

Description of work

Add an OPI for the Kicker PSU. Also refactored the Oscilloscope OPI to use linked OPI's as the Kicker PSU OPI embeds the Oscilloscope web view inside it.

Ticket

#3404

Acceptance criteria

  • The Kicker PSU OPI works with the DAQ and the Kicker IOC.
  • The TDS 3000 Trace OPI still works as before (see #3406 )

Unit tests

None

System tests

None.

Documentation

None added.


Code Review

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?
  • Have the changes been documented in the release notes?

Final Steps

  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

Copy link
Contributor

@Alistair-McGann-Tessella Alistair-McGann-Tessella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get the GUI to compile so I can't test the OPI.

</scale_options>
<scripts />
<show_scrollbar>false</show_scrollbar>
<text>Voltage:&#xD;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OPI format checker complains here that this label does not end with a colon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant