Ticket3071 add ioc kicker #790
Open
+878
−241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
August 15, 2018 14:10
…trace' into Ticket3071_Add_IOC_KICKER
ghost
mentioned this pull request
Alistair-McGann-Tessella
suggested changes
Sep 4, 2018
| </scale_options> | ||
| <scripts /> | ||
| <show_scrollbar>false</show_scrollbar> | ||
| <text>Voltage:
 |
There was a problem hiding this comment.
The OPI format checker complains here that this label does not end with a colon
added 4 commits
September 6, 2018 12:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Add an OPI for the Kicker PSU. Also refactored the Oscilloscope OPI to use linked OPI's as the Kicker PSU OPI embeds the Oscilloscope web view inside it.
Ticket
#3404
Acceptance criteria
Unit tests
None
System tests
None.
Documentation
None added.
Code Review
Final Steps