Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbv_at_setpoint indicator as red border around param #987

Merged
merged 6 commits into from
Dec 10, 2019

Conversation

ThomasLohnert
Copy link
Contributor

@ThomasLohnert ThomasLohnert commented Nov 13, 2019

Description of work

When a parameter is not moving and has not arrived at its setpoint, this error is now highlighted as a red border around the whole parameter "container". This is because a) it brings it in line with how such an error is highlighted in the SECI table of motors (and possibly in the IBEX table of motors in the future, see #4035, and b) because it makes it more distinct from the newly added alarms around parameter readback values.

Related PRs:
ISISComputingGroup/EPICS-inst_servers#244
ISISComputingGroup/EPICS-IOC_Test_Framework#258

Ticket

ISISComputingGroup/IBEX#3892

Acceptance criteria

  • Parameter alarms are clearly visible on reflectometry front panel
  • Paramaters "not at rbv" are clearly visible on the reflectometry front panel
  • Both of the above simultaneously

Unit tests

None

System tests

None

Documentation

None. Ticket to create documentation once the UI is less in flux created here.


Code Review

  • Is the code of an acceptable quality?
  • Do the changes function as described and is it robust?
  • Have the changes been documented in the release notes?

Final Steps

  • Reviewer has moved the release notes entry for this ticket in the "Changes merged into master" section

@aaron-long
Copy link
Member

  • Fix overlap on column headers under Important beamline parameters

overlap

  • The InBeamParameters seem to have not been updated to remover the RBV highlight

in_out_double

ThomasLohnert and others added 4 commits November 29, 2019 09:56
…refl_propagate_alarms# Conflicts:#base/uk.ac.stfc.isis.ibex.opis/resources/reflectometry/front_panel.opi
@aaron-long aaron-long merged commit f848c61 into master Dec 10, 2019
@aaron-long aaron-long deleted the Ticket3892_refl_propagate_alarms branch December 10, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants