rbv_at_setpoint indicator as red border around param #987
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
When a parameter is not moving and has not arrived at its setpoint, this error is now highlighted as a red border around the whole parameter "container". This is because a) it brings it in line with how such an error is highlighted in the SECI table of motors (and possibly in the IBEX table of motors in the future, see #4035, and b) because it makes it more distinct from the newly added alarms around parameter readback values.
Related PRs:
ISISComputingGroup/EPICS-inst_servers#244
ISISComputingGroup/EPICS-IOC_Test_Framework#258
Ticket
ISISComputingGroup/IBEX#3892
Acceptance criteria
Unit tests
None
System tests
None
Documentation
None. Ticket to create documentation once the UI is less in flux created here.
Code Review
Final Steps