Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why are scripting and websocket disabled? #1

Closed
mohad12211 opened this issue Jan 21, 2022 · 2 comments
Closed

why are scripting and websocket disabled? #1

mohad12211 opened this issue Jan 21, 2022 · 2 comments

Comments

@mohad12211
Copy link

Hey! aseprite-skia-bin maintainer here, thank you for refactoring the PKGBUILD's, I learned some new stuff reading your patches!
one question, why exactly did you disable scripting and websocket? I compiled aseprite with scripting and websocket with no issues, 1.2.32

@ISSOtm
Copy link
Owner

ISSOtm commented Jan 21, 2022

I disabled them to pull in less dependencies (it may be compiling fine on your machine if the deps are already there, but it doesn't on mine) and to reduce the already fairly large build time. (IIRC, the libs pulled in by those features don't have any options to make them shared, and I was reluctant to apply more patches.)

I also believe that previous versions had no scripting support, or that it wasn't seeing much use, making that decision's impact low. But it's an "administrative" decision nonetheless, so my plan of action was to disable it until someone requested it, at which point we'd review the dependencies etc. again.

@ISSOtm
Copy link
Owner

ISSOtm commented Aug 1, 2023

Note: the package aseprite enabled the functionality at users' requests anyway. ImperatorStorm/PKGBUILDs@8e61c3a

@ISSOtm ISSOtm closed this as completed Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants