Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add variable nesting and map type #139

Closed
wants to merge 0 commits into from
Closed

Conversation

solaeus
Copy link

@solaeus solaeus commented Jun 24, 2023

I like this project a lot and the code is very nice so I wanted to try this issue #117.

This is a rough draft that currently only supports getting values from up to two levels of nesting. I have a fork with a more complete solution but this was an attempt to change as little as possible. Some tests fail due to the new syntax and a new error type.

If there's still interest in this feature I can either try to find a solution in the existing code or use the technique I used in my fork, which was to create a new context type that can be wrapped in a value.

cargo run --bin evalexpr 'x.y = 1; x.z = 2; x.a.b = 3; x.c.d.e = 8; x'
# ( a = ( b = 3; ); z = 2; y = 1; c = ( d.e = 8; ); )

@solaeus solaeus marked this pull request as draft June 24, 2023 09:36
@ISibboI ISibboI self-assigned this Jun 27, 2023
@ISibboI
Copy link
Owner

ISibboI commented Jun 27, 2023

Thank you! This looks good so far. I think it would be a nice-to-have feature.

@Dzordzu
Copy link

Dzordzu commented Jan 12, 2024

Hi. Any progress on this?

@solaeus
Copy link
Author

solaeus commented Jan 12, 2024

I'm no longer using evalexpr but I'll take another look at this issue next week. If this is still the closest that we've gotten to this feature I will try to get it merged.

@solaeus
Copy link
Author

solaeus commented Jan 23, 2024

Sorry this is taking longer than I thought, some other stuff came up but I am working to get this done.

@Dzordzu
Copy link

Dzordzu commented Jan 24, 2024

Easy. Thanks for you efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants