Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to python3 #445

Open
MatthewJohn opened this issue Jun 25, 2019 · 2 comments
Open

Upgrade to python3 #445

MatthewJohn opened this issue Jun 25, 2019 · 2 comments
Labels
Big Big task High Priority
Milestone
Release 11.0.0

Comments

@MatthewJohn
Copy link
Collaborator

Python 2.7 supports ends in 2020.
@MatthewJohn MatthewJohn added this to the Release 11.0.0 milestone Aug 19, 2019
@MatthewJohn
Copy link
Collaborator Author

Given python2.7 ends support this year (ish), this should be migrated ASAP

@MatthewJohn MatthewJohn mentioned this issue Feb 20, 2020
Open
MatthewJohn added a commit that referenced this issue Feb 20, 2020
@MatthewJohn
Ticket #445: Update scripts referencing python2.7 directories to python3
dfb9599
MatthewJohn added a commit that referenced this issue Feb 20, 2020
@MatthewJohn
Issue #445: Fix all print statements
169d09b
MatthewJohn added a commit that referenced this issue Feb 20, 2020
@MatthewJohn
Issue #445: Fix string interpolation in mcvirt-agent and mcvirt-commo…
041a34a 
…n package
MatthewJohn added a commit that referenced this issue Feb 20, 2020
@MatthewJohn
Issue #445: Use 2to3 to update source in usr/lib
e8c6b61
MatthewJohn added a commit that referenced this issue Feb 20, 2020
@MatthewJohn
Issue #445: Fix mcvirt bin after 2to3 tool
b3c5bd4
MatthewJohn added a commit that referenced this issue Feb 20, 2020
@MatthewJohn
Issue #445: Update debian dependencies to python3 packages. NOTE: pyt…
cdce16a 
…hon3-cheetah does NOT exist. Will investigate to convert to mako in #456
MatthewJohn added a commit that referenced this issue Feb 20, 2020
@MatthewJohn
Ticket #445: Update scripts referencing python2.7 directories to python3
34dd052
MatthewJohn added a commit that referenced this issue Feb 20, 2020
@MatthewJohn
Issue #445: Move source into python3 directory
bb02f63
@MatthewJohn MatthewJohn mentioned this issue Feb 20, 2020
Open
MatthewJohn added a commit that referenced this issue Feb 20, 2020
@MatthewJohn
Issue #445 #456: Update DRBD config to use mako for templating
267d239
MatthewJohn added a commit that referenced this issue Feb 20, 2020
@MatthewJohn
Issue #445 #456: Update DRBD resource and libvirt config templating t…
c681f35 
…o use mako
MatthewJohn added a commit that referenced this issue Feb 20, 2020
@MatthewJohn
Issue #445 #456: Update debian control, replacing cheetah with mako a…
bf65636 
…s requirement
MatthewJohn added a commit that referenced this issue Feb 20, 2020
@MatthewJohn
T #445: Fix string formatting for python3 in group.py
5d1dabf
@MatthewJohn MatthewJohn mentioned this issue Feb 20, 2020
Open
MatthewJohn added a commit that referenced this issue Feb 20, 2020
@MatthewJohn
T #445 #457: Replace uses of TextTable with PrettyTable
0a26e0a
MatthewJohn added a commit that referenced this issue May 16, 2020
@MatthewJohn
T #445: Update script interpreters and fix exception printing in mcvi…
4d2ed25 
…rt executable
MatthewJohn added a commit that referenced this issue May 16, 2020
@MatthewJohn
T #445: Replace method of generating random session ID, due to change…
a34c5d1 
…s in python3
MatthewJohn added a commit that referenced this issue May 16, 2020
@MatthewJohn
T #445: Add encoding to IDs before hashing in pyro object
ea8c081
MatthewJohn added a commit that referenced this issue May 16, 2020
@MatthewJohn
T #445: Fix encoding of XMl from ET to use unicode (as utf-8 now retu…
0da8973 
…rns a bytestring)
MatthewJohn added a commit that referenced this issue May 16, 2020
@MatthewJohn
T #445: Fix return of current DB schema version
dd6bfe7
MatthewJohn added a commit that referenced this issue May 16, 2020
@MatthewJohn
T #445: Fix error logging in parser
93b1a40
MatthewJohn added a commit that referenced this issue May 16, 2020
@MatthewJohn
T #445: Update control to allow either naming of ldap package
0f44110
@MatthewJohn
Copy link
Collaborator Author

MatthewJohn commented May 16, 2020 •
edited

Latest test results:

======================================================================
ERROR: test_remove_user_account (mcvirt.test.auth_tests.AuthTests)
Delete a user through the parser.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/mcvirt/test/auth_tests.py", line 65, in setUp
    self.test_user = self.create_test_user(self.TEST_USERNAME, self.TEST_PASSWORD)
  File "/usr/lib/python3/dist-packages/mcvirt/test/auth_tests.py", line 48, in create_test_user
    self.user_factory.create(username, password)
  File "/usr/local/lib/python3.5/dist-packages/Pyro4/core.py", line 171, in __call__
    return self.__send(self.__name, args, kwargs)
  File "/usr/local/lib/python3.5/dist-packages/Pyro4/core.py", line 428, in _pyroInvoke
    raise data
TypeError: b'b63d170e93146758ae4eb82c326f9766739dca84e03c8c8ba019346d6ec72c1a' is not JSON serializable

======================================================================
ERROR: test_clone_local (mcvirt.test.virtual_machine.virtual_machine_tests.VirtualMachineTests)
Test the VM cloning in MCVirt using the argument parser.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/mcvirt/test/virtual_machine/virtual_machine_tests.py", line 211, in test_clone_local
    fh.write(test_data)
TypeError: write() argument must be str, not bytes

======================================================================
ERROR: test_clone_local (mcvirt.test.virtual_machine.virtual_machine_tests.VirtualMachineTests)
Test the VM cloning in MCVirt using the argument parser.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/mcvirt/test/test_base.py", line 123, in tearDown
    self.stop_and_delete(self.test_vms['TEST_VM_1']['name'])
  File "/usr/lib/python3/dist-packages/mcvirt/test/test_base.py", line 197, in stop_and_delete
    vm_object.delete()
  File "/usr/local/lib/python3.5/dist-packages/Pyro4/core.py", line 171, in __call__
    return self.__send(self.__name, args, kwargs)
  File "/usr/local/lib/python3.5/dist-packages/Pyro4/core.py", line 428, in _pyroInvoke
    raise data
mcvirt.exceptions.ExternalStorageCommandErrorException: Error whilst removing logical volume:
External command failure. See MCVirt log for more information

======================================================================
ERROR: test_duplicate_local (mcvirt.test.virtual_machine.virtual_machine_tests.VirtualMachineTests)
Perform test_duplicate test with Local storage.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/mcvirt/test/virtual_machine/virtual_machine_tests.py", line 269, in test_duplicate_local
    self.test_duplicate('Local')
  File "/usr/lib/python3/dist-packages/mcvirt/test/virtual_machine/virtual_machine_tests.py", line 281, in test_duplicate
    test_vm_parent = self.create_vm('TEST_VM_1', 'Local')
  File "/usr/lib/python3/dist-packages/mcvirt/test/test_base.py", line 162, in create_vm
    available_nodes=available_nodes)
  File "/usr/local/lib/python3.5/dist-packages/Pyro4/core.py", line 171, in __call__
    return self.__send(self.__name, args, kwargs)
  File "/usr/local/lib/python3.5/dist-packages/Pyro4/core.py", line 428, in _pyroInvoke
    raise data
mcvirt.exceptions.VmAlreadyExistsException: VM already exists

======================================================================
ERROR: test_create_backup_snapshot (mcvirt.test.virtual_machine.virtual_machine_tests.VirtualMachineTests)
Create VM backup snapshot.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/mcvirt/test/virtual_machine/virtual_machine_tests.py", line 776, in test_create_backup_snapshot
    fh.write(test_data)
TypeError: write() argument must be str, not bytes

----------------------------------------------------------------------

MatthewJohn added a commit that referenced this issue May 16, 2020
@MatthewJohn
T #445: Update user base generation to use straing and random.choices…
b557670 
… instead of the use of hexlify
MatthewJohn added a commit that referenced this issue May 16, 2020
@MatthewJohn
T #445: Update virtual machine tests to open hard drive with binary f…
f625891 
…lag to write binary data
MatthewJohn added a commit that referenced this issue May 17, 2020
@MatthewJohn
T #445: Fix use of missing function choices from random
2d6b7d4
MatthewJohn added a commit that referenced this issue May 17, 2020
@MatthewJohn
T #445: Remove punctuation from salt
d0e63b7
MatthewJohn added a commit that referenced this issue May 18, 2020
@MatthewJohn
T #445: Convert dd count and bs to int before passing to command, as …
87893d4 
…this was converted to float with single dp in string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Big Big task High Priority
Projects
None yet
Milestone
Release 11.0.0
Development

No branches or pull requests
1 participant
@MatthewJohn