Skip to content
This repository has been archived by the owner on Mar 16, 2023. It is now read-only.

⬆️ Mainteance: update requirements + pre-commit #45

Merged

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 1, 2023

What do these changes do?

massive requirements update
pre-commit update and usage of same pre-commit hooks as in osparc-simcore

Related issue/s

fixes ITISFoundation/osparc-issues#885
fixes ITISFoundation/osparc-issues#675

How to test

Checklist

@sanderegg sanderegg added the dependencies Pull requests that update a dependency file label Mar 1, 2023
@sanderegg sanderegg added this to the Mithril milestone Mar 1, 2023
@sanderegg sanderegg requested a review from pcrespov March 1, 2023 21:31
@sanderegg sanderegg self-assigned this Mar 1, 2023
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
I still need to check for a couple of details but probably we can get rid of _tools.txt listings forever :-) More will follow

@codecov
Copy link

codecov bot commented Mar 1, 2023

Codecov Report

Merging #45 (c155c3a) into main (4d5a595) will decrease coverage by 0.4%.
The diff coverage is 94.7%.

@@           Coverage Diff           @@
##            main     #45     +/-   ##
=======================================
- Coverage   84.3%   84.0%   -0.4%     
=======================================
  Files          8       8             
  Lines        378     377      -1     
=======================================
- Hits         319     317      -2     
- Misses        59      60      +1     
Flag Coverage Δ
integrationtests 79.3% <94.7%> (-0.4%) ⬇️
unittests 42.4% <47.3%> (+0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rver/src/osparc_gateway_server/backend/settings.py 100.0% <ø> (ø)
...y-server/src/osparc_gateway_server/remote_debug.py 20.0% <50.0%> (ø)
...server/src/osparc_gateway_server/backend/models.py 82.9% <100.0%> (ø)
...server/src/osparc_gateway_server/backend/osparc.py 82.1% <100.0%> (-0.8%) ⬇️
...-server/src/osparc_gateway_server/backend/utils.py 90.4% <100.0%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sanderegg sanderegg changed the title ⬆️ Maintenacne: update requirements + pre-commit ⬆️ Mainteance: update requirements + pre-commit Mar 2, 2023
@sanderegg sanderegg merged commit fba2957 into ITISFoundation:main Mar 2, 2023
@sanderegg sanderegg deleted the maintenance/update_requirements branch March 2, 2023 11:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppTeam Std Simulations on S4L/AWS M1-12 Maintenance and DevOps
2 participants