Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy script for aws production doesn't run #250

Closed
Tracked by #675
Surfict opened this issue Jun 27, 2023 · 2 comments
Closed
Tracked by #675

Deploy script for aws production doesn't run #250

Surfict opened this issue Jun 27, 2023 · 2 comments
Assignees
Labels
FAST p:mid-prio t:bug Something isn't working
Milestone

Comments

@Surfict
Copy link
Collaborator

Surfict commented Jun 27, 2023

During the last release, the script to deploy the entire stack in aws production couldn't be launched. It is checking if the git repo is up-to-date with origin/main - which is not the case any more as we checkout on a tag now.

@Surfict Surfict changed the title Deploy script for aws production is not launching Deploy script for aws production doesn't run Jun 27, 2023
@mrnicegyu11 mrnicegyu11 added t:bug Something isn't working p:mid-prio labels Jun 28, 2023
@mrnicegyu11
Copy link
Member

In the current workflow regarding simcore releases, we check out the osparc-ops repos at the matching tag of the release, and thus not at HEAD. The VCS check will then, as intended, fail. We need to either make the VCS check aware of release-tags or disable the check on the deployment targets:

  • dalco
  • aws
  • public

The latter is the more reasonable option for the moment.

@mrnicegyu11
Copy link
Member

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FAST p:mid-prio t:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants