Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable vcs check on aws/dalco/public deployment #313

Merged

Conversation

mrnicegyu11
Copy link
Member

Currently, we check out specific tags on deployments that run staging (pre-release) or production (release) version, aossciated to the specific release, like v1.58.0. The makefile assert checking that one is on the master branch of the github repo gets in the wa here, so we disable it to enable to currently used workflows.

Bonus:

  • Clearer cmd-option naming
  • remove stale comment

Adresses #250

@mrnicegyu11 mrnicegyu11 added t:bug Something isn't working FAST labels Aug 16, 2023
@mrnicegyu11 mrnicegyu11 added this to the Baklava milestone Aug 16, 2023
@mrnicegyu11 mrnicegyu11 self-assigned this Aug 16, 2023
@mrnicegyu11 mrnicegyu11 merged commit 8acd075 into ITISFoundation:main Aug 17, 2023
1 check passed
@mrnicegyu11 mrnicegyu11 deleted the fix/stagingProductionVCSCheck branch August 17, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FAST t:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant