Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pg_backup starts #105

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Fix pg_backup starts #105

merged 1 commit into from
Feb 15, 2023

Conversation

Surfict
Copy link
Collaborator

@Surfict Surfict commented Feb 15, 2023

When pg-backup is started before the Postgres container, it will fail with this error :
image
The container itself doesn't fail and still runs, but doesn't do any backup. To solve this, we need to ensure that pgsql container is started and ready to accept connections before starting pg-backup.

Fix #443 ops issue.

@Surfict Surfict self-assigned this Feb 15, 2023
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this!

Quick question: What happens when the postgres container is restarted (for example when releasing new code)

@Surfict
Copy link
Collaborator Author

Surfict commented Feb 15, 2023

Thanks a lot for this!

Quick question: What happens when the postgres container is restarted (for example when releasing new code)

I didn't test it but from my comprehension of how pg-backup works, it still works. It will check the container at startup and fails without doing backup if it doesn't find it. If it can't do a backup later, it will try again at the next planned window.

I guess if I am wrong and it prevents if from functioning, we will see it in the tests, but so far I have never seen it after months of functioning so I believe it works.

@Surfict Surfict merged commit 46458e8 into ITISFoundation:main Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants