Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add deployment labels for clusters_keeper microservices #312

Merged
merged 2 commits into from
Aug 15, 2023
Merged

✨ Add deployment labels for clusters_keeper microservices #312

merged 2 commits into from
Aug 15, 2023

Conversation

mrnicegyu11
Copy link
Member

@mrnicegyu11 mrnicegyu11 commented Aug 15, 2023 •
edited

Bonus:

  • Update pre-commit hooks
  • Update pre-commit hooks' used python version to 3.10
  • Removes deprecated file comment about logspout (which we dont use anymore)

@mrnicegyu11 mrnicegyu11 added this to the Baklava milestone Aug 15, 2023
@mrnicegyu11 mrnicegyu11 self-assigned this Aug 15, 2023
@mrnicegyu11 mrnicegyu11 marked this pull request as ready for review August 15, 2023 09:11
sanderegg
sanderegg approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the hostname part in docker-compose. this is not unique

services/simcore/docker-compose.yml Outdated Show resolved Hide resolved
services/simcore/docker-compose.yml Show resolved Hide resolved
@mrnicegyu11 mrnicegyu11 merged commit 21450d0 into ITISFoundation:main Aug 15, 2023
2 checks passed
@mrnicegyu11 mrnicegyu11 mentioned this pull request Sep 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanderegg sanderegg sanderegg approved these changes

@YuryHrytsuk YuryHrytsuk Awaiting requested review from YuryHrytsuk YuryHrytsuk is a code owner

Assignees

@mrnicegyu11 mrnicegyu11

Labels
p:high-prio
Projects
None yet
Milestone
Baklava
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrnicegyu11 @sanderegg