Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add docker resource limits to 20% services #329

Merged
merged 7 commits into from
Aug 30, 2023
Merged

✨ Add docker resource limits to 20% services #329

merged 7 commits into from
Aug 30, 2023

Conversation

YuryHrytsuk
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk commented Aug 28, 2023 •
edited

Service updated

@YuryHrytsuk YuryHrytsuk added t:enhancement New feature or request p:mid-prio t:infra-ops Adjustments to the way or resources with that microservices are run labels Aug 28, 2023
@YuryHrytsuk YuryHrytsuk added this to the Baklava milestone Aug 28, 2023
@YuryHrytsuk YuryHrytsuk self-assigned this Aug 28, 2023
sanderegg
sanderegg reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

mrnicegyu11
mrnicegyu11 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, maybe have a look at my comments.

Very much needed contribution!

services/pg-backup/docker-compose.yml.j2 Outdated Show resolved Hide resolved
services/redis-commander/docker-compose.yml Outdated Show resolved Hide resolved
pcrespov
pcrespov reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! 🎉

@YuryHrytsuk
Copy link
Collaborator Author

It address the part of #330

GitHK
GitHK reviewed Aug 29, 2023
View reviewed changes
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think overall the settings look very low.
Q: did you try the limited services with datasets comparable to the ones were have on master?

services/admin-panels/docker-compose.yml.j2 Outdated Show resolved Hide resolved
services/adminer/docker-compose.yml Outdated Show resolved Hide resolved
services/deployment-agent/docker-compose.yml.j2 Outdated Show resolved Hide resolved
services/filestash/docker-compose.yml Outdated Show resolved Hide resolved
services/graylog/docker-compose.yml Outdated Show resolved Hide resolved
@YuryHrytsuk YuryHrytsuk requested a review from GitHK August 29, 2023 14:17
@YuryHrytsuk YuryHrytsuk marked this pull request as ready for review August 30, 2023 06:31
@YuryHrytsuk YuryHrytsuk merged commit 11ca506 into ITISFoundation:main Aug 30, 2023
2 checks passed
@mrnicegyu11 mrnicegyu11 mentioned this pull request Sep 8, 2023
Closed
@mrnicegyu11 mrnicegyu11 changed the title Add docker resource limits to 20% services ✨ Add docker resource limits to 20% services Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@GitHK GitHK GitHK approved these changes

@mrnicegyu11 mrnicegyu11 mrnicegyu11 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@mguidon mguidon Awaiting requested review from mguidon

@matusdrobuliak66 matusdrobuliak66 Awaiting requested review from matusdrobuliak66

Assignees

@YuryHrytsuk YuryHrytsuk

Labels
p:mid-prio t:enhancement New feature or request t:infra-ops Adjustments to the way or resources with that microservices are run
Projects
None yet
Milestone
Baklava
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YuryHrytsuk @GitHK @mrnicegyu11 @pcrespov @sanderegg