Fix/product cors #89
Merged
Fix/product cors #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
approved these changes
Jan 23, 2023
pcrespov
approved these changes
Jan 23, 2023
GitHK
approved these changes
Jan 24, 2023
mrnicegyu11
added a commit
that referenced
this pull request
Jan 24, 2023
* Delete docker compose of ops traefik * Fix bug: MACHINE_FQDNS is DEPLOYMENT_FQDNS * Necessary fixes for v1.42.0 : Add product to CORS rules Co-authored-by: Dustin Kaiser <kaiser@itis.swiss>
mrnicegyu11
added a commit
that referenced
this pull request
Jan 24, 2023
* Delete docker compose of ops traefik * Fix bug: MACHINE_FQDNS is DEPLOYMENT_FQDNS * Necessary fixes for v1.42.0 : Add product to CORS rules Co-authored-by: Dustin Kaiser <kaiser@itis.swiss>
mrnicegyu11
added a commit
that referenced
this pull request
Jan 31, 2023
* Minor Traefik fix * Fix/product cors (#89) * Delete docker compose of ops traefik * Fix bug: MACHINE_FQDNS is DEPLOYMENT_FQDNS * Necessary fixes for v1.42.0 : Add product to CORS rules Co-authored-by: Dustin Kaiser <kaiser@itis.swiss> * various mailserver changes --------- Co-authored-by: allexandre <allexandre@itis.swiss> Co-authored-by: Dustin Kaiser <kaiser@itis.swiss> Co-authored-by: Dustin Kaiser <mail@dustinkaiser.eu>
mrnicegyu11
added a commit
that referenced
this pull request
Jan 31, 2023
* Minor Traefik fix * Fix/product cors (#89) * Delete docker compose of ops traefik * Fix bug: MACHINE_FQDNS is DEPLOYMENT_FQDNS * Necessary fixes for v1.42.0 : Add product to CORS rules Co-authored-by: Dustin Kaiser <kaiser@itis.swiss> * various mailserver changes --------- Co-authored-by: allexandre <allexandre@itis.swiss> Co-authored-by: Dustin Kaiser <kaiser@itis.swiss> Co-authored-by: Dustin Kaiser <mail@dustinkaiser.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes CORS problems encountered during the v1.42.0 release, related to products which have unique domains.
This needs to be propagated to staging & prod.
Bonus: Fix undetected bug where
MACHINE_FQDNSwas used (it is now calledDEPLOYMENT_FQDNS