Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Support versioning on website #51

Conversation

bisgaard-itis
Copy link
Collaborator

@bisgaard-itis bisgaard-itis commented Jul 11, 2023

What do these changes do?

  • Support documentation of different client versions on the website.
  • Automatically generate markdown from the jupyter notebooks so that the documentation is always up-to-date and tested.

Now the front page looks like this:
image
and by hovering the mouse of the Python icon on the top right a dropdown appears and the user can select which client version she wants to see the documentation for. Let me know if you don't like the text I put on the front page @elisabettai. I can also show you how the documentation works if you like and then you can modify it if you want.

Related issue/s

How to test

@bisgaard-itis bisgaard-itis self-assigned this Jul 11, 2023
@bisgaard-itis bisgaard-itis added the documentation Improvements or additions to documentation label Jul 11, 2023
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multi-version doc! fancy! :-)

perhaps the main-page needs a bit more of love :-) ... I think it should be more prominent the access to the clients e.g. a big button in the center or something. we should ask for help to UI/UX team :-)

In any case, just go ahead and we will iterate with that part later!

@@ -86,6 +86,10 @@ install-dev: _check_venv_active ## install packages for development
install-test: _check_venv_active install-dev ## install packages for testing client
pip install -r $(PYTHON_DIR)/requirements/test.txt

.PHONY: install-doc
install-test: _check_venv_active install-dev ## install packages for generating documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

install-test or install-doc? i think the latter, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Thanks.
I have corrected this

Copy link
Contributor

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I agree with @pcrespov that the web-page looks a bit sad from the EI/UX perspective, but we can change that later. 😉

Just a small thought: I guess we're using this website to show the BasicTutorial (and the ones that will follow in the future).

Just a small thought: we also have our pages on pypi: https://pypi.org/project/osparc/0.5.0/ for different versions. Maybe it might make sense to link them here as well?

Currently there is only a single client:

- [Python](../clients/python/docs/README.md)
[Osparc](https://osparc.io/) is a platform for developing, running and sharing life sience simulations. This site documents clients for interacting with osparc programatically. Choose your favorite programming language in the top-right navigation bar and get started.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would replace the link with:

o²S²PARC.

And re-use the text we have in the information page.
"is an open, cloud-based platform for the development, execution and sharing of computational models, simulations, and data analysis pipelines, and the presentation of results"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. I have fixed this.

@bisgaard-itis
Copy link
Collaborator Author

multi-version doc! fancy! :-)

perhaps the main-page needs a bit more of love :-) ... I think it should be more prominent the access to the clients e.g. a big button in the center or something. we should ask for help to UI/UX team :-)

In any case, just go ahead and we will iterate with that part later!

I definitely agree this site could need some love from a UI/UX guru.

@bisgaard-itis
Copy link
Collaborator Author

Very nice! I agree with @pcrespov that the web-page looks a bit sad from the EI/UX perspective, but we can change that later. wink

Just a small thought: I guess we're using this website to show the BasicTutorial (and the ones that will follow in the future).

Just a small thought: we also have our pages on pypi: https://pypi.org/project/osparc/0.5.0/ for different versions. Maybe it might make sense to link them here as well?

Yes, the tutorials will all be available through this site. In the current version, when one hits the version button one gets a list of tutorials which are relevant for that version (so currently only the single basic tutorial).

About the pages on pypi I don't know exactly how that is update. I guess it is done once when we publish there. So I will definitely take this into account when we publish the next version of our package. For maintainability I guess the easiest setup would be if we just link to our "own" site there. So that we don't have to manually keep things in sync.

@bisgaard-itis bisgaard-itis merged commit 3719bd4 into ITISFoundation:master Jul 17, 2023
8 checks passed
@bisgaard-itis bisgaard-itis deleted the support-versioning-on-website branch July 17, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants