Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speedup webserver booting time #3515

Closed
pcrespov opened this issue Nov 4, 2022 · 1 comment · Fixed by #4490
Closed

Speedup webserver booting time #3515

pcrespov opened this issue Nov 4, 2022 · 1 comment · Fixed by #4490
Assignees
@pcrespov @matusdrobuliak66
Labels
a:services-library issues on packages/service-libs t:maintenance Some planned maintenance work
Milestone
Watermelon

Comments

@pcrespov
Copy link
Member

pcrespov commented Nov 4, 2022 •
edited

While debugging, changing the code would reboot the web-server and due to the long plugin startup time, it takes considerable time to boot.

This speedup will reduce considerable debugging time!

Possible bottlenecks

  • rest plugin is very slow loading OAS. Reduce json size by reusing components . remove all openapi_core validation and move all to pydantic + servicelib.aiohttp.request_validation

Related
@pcrespov pcrespov added the t:maintenance Some planned maintenance work label Nov 4, 2022
@pcrespov pcrespov self-assigned this Nov 4, 2022
@sanderegg sanderegg mentioned this issue Dec 12, 2022
Closed
@pcrespov
Copy link
Member Author

  • rm dependencies on rest_utils.extract_and_validate
  • rm dependencies on rest_routing.* such as rest_routing.get_handlers_from_namespace
  • rm dependencies on rest_validators.*
  • rm dependencies on SOME of the middlewares in rest_middleware.*

@pcrespov pcrespov mentioned this issue Dec 15, 2022
Merged
4 tasks
@pcrespov pcrespov added a:infra+ops maintenance of infrastructure or operations (discussed in retro) t:enhancement Improvement or request on an existing feature a:services-library issues on packages/service-libs and removed t:enhancement Improvement or request on an existing feature a:infra+ops maintenance of infrastructure or operations (discussed in retro) labels Mar 5, 2023
@pcrespov pcrespov added this to the Jelly Beans milestone Apr 7, 2023
@pcrespov pcrespov modified the milestones: Jelly Beans, Watermelon Jun 8, 2023
@pcrespov pcrespov mentioned this issue Jul 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcrespov pcrespov

@matusdrobuliak66 matusdrobuliak66

Labels
a:services-library issues on packages/service-libs t:maintenance Some planned maintenance work
Projects
None yet
Milestone
Watermelon
Development

Successfully merging a pull request may close this issue.

♻️ Maintenance: removes openapi-core from aiohttp services pcrespov/osparc-simcore
2 participants
@pcrespov @matusdrobuliak66