♻️ Is3515/ deprecates servicelib.extract_and_validate

[pcrespov]

What do these changes do?

The main goal is to remove the dependency from openapi-core introduced in servicelib.aiohttp. As a first PR, this will replace servicelib.rest_utils.extract_and_validate by pydantic models that validate requests from serviceslib.aiohttp.requests_validation

• ♻️ Removes dependencies on servicelib.rest_utils.extract_and_validate from all services except webserver's storageplugin (will do in a separate PR)
• ♻️ Refactors webserver's storage plugin:
  • Cleanup opeapi-storage.yml and creates autogenerator api/specs/webserver/scripts/openapi_storage.py
  • Defines storage_schemas pydantic models
  • Next PR will remove extract_and_validate from this module
• 🔨 new helper pytest_simcore.pydantic_models.iter_model_examples_in_module

Related issue/s

• Speedup webserver booting time #3515: rm dependencies on rest_utils.extract_and_validate

How to test

Checklist

• make openapi.json (no change)
• Unit tests for the changes exist
• Runs in the swarm
• Documentation reflects the changes

[codecov]

Codecov Report

Merging #3691 (83fcb4d) into master (b84c3e5) will increase coverage by 1.2%.
The diff coverage is 99.3%.

@@           Coverage Diff            @@
##           master   #3691     +/-   ##
========================================
+ Coverage    83.2%   84.4%   +1.2%     
========================================
  Files         848     884     +36     
  Lines       35603   37551   +1948     
  Branches      787     785      -2     
========================================
+ Hits        29634   31718   +2084     
+ Misses       5759    5623    -136     
  Partials      210     210             

Flag	Coverage Δ
integrationtests	67.5% <20.6%> (+6.4%)	⬆️
unittests	81.7% <99.3%> (+0.2%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s/service-library/src/servicelib/rest_constants.py	0.0% <ø> (ø)
...ver/src/simcore_service_webserver/rest_handlers.py	100.0% <ø> (ø)
...rvice-library/src/servicelib/aiohttp/rest_utils.py	75.0% <75.0%> (+8.3%)	⬆️
...age/src/simcore_service_storage/handlers_health.py	100.0% <100.0%> (ø)
.../src/simcore_service_webserver/catalog_handlers.py	43.3% <100.0%> (ø)
...src/simcore_service_webserver/clusters/handlers.py	100.0% <100.0%> (+2.9%)	⬆️
...mcore_service_webserver/login/api_keys_handlers.py	95.6% <100.0%> (ø)
...imcore_service_webserver/meta_modeling_handlers.py	84.2% <100.0%> (ø)
...rvice_webserver/projects/projects_handlers_crud.py	93.1% <100.0%> (ø)
...r/src/simcore_service_webserver/storage_schemas.py	100.0% <100.0%> (ø)
... and 67 more

[GitHK]

looking nice.
Question: will this already speedup the boot time?

[sanderegg]

Great! very much looking forward to removing these old things!
Can you just double check my 2 comments before merging. thanks!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication