Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix headers check in webserver.reverse_proxy #428

Closed
pcrespov opened this issue Dec 5, 2018 · 0 comments · Fixed by #429
Closed

fix headers check in webserver.reverse_proxy #428

pcrespov opened this issue Dec 5, 2018 · 0 comments · Fixed by #429
Assignees
@pcrespov
Labels
bug buggy, it does not work as expected

Comments

@pcrespov
Copy link
Member

pcrespov commented Dec 5, 2018

ERROR:aiohttp.server:Error handling request,
Traceback (most recent call last):,
File "/home/scu/.venv/lib/python3.6/site-packages/aiohttp/web_protocol.py", line 378, in start,
resp = await self._request_handler(request),
File "/home/scu/.venv/lib/python3.6/site-packages/aiohttp/web_app.py", line 341, in _handle,
resp = await handler(request),
File "/home/scu/.venv/lib/python3.6/site-packages/aiohttp/web_middlewares.py", line 88, in impl,
return await handler(request),
File "/home/scu/.venv/lib/python3.6/site-packages/aiohttp_session/init.py", line 149, in factory,
response = await handler(request),
File "/home/scu/.venv/lib/python3.6/site-packages/servicelib/rest_middlewares.py", line 47, in _middleware,
return await handler(request),
File "/home/scu/.venv/lib/python3.6/site-packages/servicelib/rest_middlewares.py", line 145, in _middleware,
return await handler(request),
File "/home/scu/.venv/lib/python3.6/site-packages/simcore_service_webserver/reverse_proxy/routing.py", line 95, in do_route,
proxy_path=proxy_path),
File "/home/scu/.venv/lib/python3.6/site-packages/simcore_service_webserver/reverse_proxy/handlers/jupyter.py", line 40, in handler,
if reqH['connection'].lower() == 'upgrade' and reqH['upgrade'].lower() == 'websocket' and req.method == 'GET':,
File "multidict/_multidict.pyx", line 62, in multidict._multidict._Base.getitem,
File "multidict/_multidict.pyx", line 57, in multidict._multidict._Base._getone,
File "multidict/_multidict.pyx", line 52, in multidict._multidict._Base._getone,
KeyError: 'connection',��
@pcrespov pcrespov self-assigned this Dec 5, 2018
@pcrespov pcrespov added backlog bug buggy, it does not work as expected and removed backlog labels Dec 5, 2018
pcrespov added a commit to pcrespov/osparc-simcore that referenced this issue Dec 5, 2018
@pcrespov
Fixes ITISFoundation#428: safe get in reverse proxy
ec93157
@pcrespov pcrespov mentioned this issue Dec 5, 2018
Merged
5 tasks
@ghost ghost added review and removed in progress labels Dec 5, 2018
pcrespov added a commit that referenced this issue Dec 5, 2018
@pcrespov
Is428/fix header check (#429)
19a4a56 
* Fixes #428: safe get in reverse proxy
@ghost ghost removed the review label Dec 5, 2018
pcrespov added a commit to pcrespov/osparc-simcore that referenced this issue Dec 5, 2018
@pcrespov
Merge branch 'master' into is385/reverse-extension
5b12ca4 
 Conflicts:
	services/web/server/src/simcore_service_webserver/reverse_proxy/handlers/jupyter.py

- Merges fixes from ITISFoundation#428
@pcrespov pcrespov reopened this Dec 6, 2018
@pcrespov pcrespov added the review label Dec 6, 2018
@pcrespov pcrespov closed this as completed Dec 6, 2018
@pcrespov pcrespov removed the review label Dec 6, 2018
@elisabettai elisabettai mentioned this issue Oct 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pcrespov pcrespov

Labels
bug buggy, it does not work as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Is428/fix header check pcrespov/osparc-simcore
1 participant
@pcrespov