Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OSPARC_API_HOST, OSPARC_API_KEY and OSPARC_API_SECRET available in comp services #5853

Closed
Tracked by #1365
wvangeit opened this issue May 22, 2024 · 2 comments · Fixed by #5858
Closed
Tracked by #1365
Assignees
Labels
t:enhancement Improvement or request on an existing feature

Comments

@wvangeit
Copy link
Contributor

wvangeit commented May 22, 2024

To be able to use the osparc python API client in computational services, we need the API host/key/secret exposed.

These variables were exposed in (e.g.) #5695

This is working in interactive services, but not in computational services. In interactive services we can have the block below in an .osparc/osparc-dakota-comp/runtime.yml file, and it exposes the variables in the service. This doesn't seem to work in computational service, since compose-spec seems dynamic-sidecar specific.

compose-spec: │ version: "3.7" │ services: │ │ osparc-dakota-comp: │ │ │ image: $${SIMCORE_REGISTRY}/simcore/services/comp/osparc-dakota-comp:$${SERVICE_VERSION} │ │ │ environment: │ │ │ │ - OSPARC_API_HOST=$${OSPARC_VARIABLE_API_HOST} │ │ │ │ - OSPARC_API_KEY=$${OSPARC_VARIABLE_API_KEY} │ │ │ │ - OSPARC_API_SECRET=$${OSPARC_VARIABLE_API_SECRET} container-http-entrypoint: osparc-dakota-comp

@sanderegg Could you help with this? Or do you have any ideas how to get the keys into the containers?

@wvangeit wvangeit transferred this issue from ITISFoundation/osparc-issues May 22, 2024
@wvangeit wvangeit added this to the Leeroy Jenkins milestone May 22, 2024
@wvangeit wvangeit added the t:enhancement Improvement or request on an existing feature label May 22, 2024
@wvangeit
Copy link
Contributor Author

FYI @pcrespov

@pcrespov pcrespov self-assigned this May 22, 2024
@pcrespov
Copy link
Member

Related with #5397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t:enhancement Improvement or request on an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants