Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes and issue with e2e utils #2311

Merged
merged 4 commits into from
May 4, 2021

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented May 3, 2021

What do these changes do?

Addresses the issue below:

Tutorial error: TypeError: Cannot use 'in' operator to search for 'state' in null

Related issue/s

How to test

Checklist

@GitHK GitHK self-assigned this May 3, 2021
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #2311 (c6be0ee) into master (535b1ba) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2311     +/-   ##
========================================
- Coverage    71.7%   71.7%   -0.1%     
========================================
  Files         506     506             
  Lines       19912   19912             
  Branches     1949    1949             
========================================
- Hits        14294   14293      -1     
- Misses       5142    5143      +1     
  Partials      476     476             
Flag Coverage Δ
integrationtests 62.0% <ø> (+<0.1%) ⬆️
unittests 67.1% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 60.6% <0.0%> (-0.3%) ⬇️

@GitHK GitHK added bug buggy, it does not work as expected e2e Bugs found by or related to the end-2-end testing labels May 3, 2021
@GitHK GitHK added this to the Schwarznasenschaf milestone May 3, 2021
tests/e2e/utils/utils.js Outdated Show resolved Hide resolved
Co-authored-by: Odei Maiz <33152403+odeimaiz@users.noreply.github.com>
@GitHK GitHK requested a review from odeimaiz May 3, 2021 15:12
@odeimaiz
Copy link
Member

odeimaiz commented May 3, 2021

I think that this fix is obsolete since the makeRequest response changed, but an extra check doesn't harm.

@GitHK GitHK merged commit ccc86f7 into ITISFoundation:master May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug buggy, it does not work as expected e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants