Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock links when pipeline is running: frontend #2795

Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 4, 2022

What do these changes do?

Disable the inputs when the pipeline is running
NoLinkConnections

Related issue/s

related to #2797

How to test

Checklist

@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Feb 4, 2022
@odeimaiz odeimaiz added this to the Rudolph+1 milestone Feb 4, 2022
@odeimaiz odeimaiz self-assigned this Feb 4, 2022
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #2795 (5b78298) into master (90cd3d2) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2795     +/-   ##
========================================
- Coverage    78.9%   78.8%   -0.1%     
========================================
  Files         670     670             
  Lines       27186   27186             
  Branches     2669    2669             
========================================
- Hits        21466   21446     -20     
- Misses       4964    4980     +16     
- Partials      756     760      +4     
Flag Coverage Δ
integrationtests 66.0% <ø> (+<0.1%) ⬆️
unittests 74.4% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/simcore_service_catalog/core/background_tasks.py 68.0% <0.0%> (-13.9%) ⬇️
...imcore_service_catalog/db/repositories/projects.py 41.6% <0.0%> (-12.5%) ⬇️
...rvice-library/src/servicelib/common_aiopg_utils.py 88.2% <0.0%> (-8.9%) ⬇️
...ce_webserver/resource_manager/garbage_collector.py 72.7% <0.0%> (-0.9%) ⬇️
...simcore_service_director_v2/modules/dask_client.py 81.9% <0.0%> (-0.7%) ⬇️
.../director/src/simcore_service_director/producer.py 61.5% <0.0%> (-0.3%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 86.4% <0.0%> (+0.5%) ⬆️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 95.8% <0.0%> (+1.1%) ⬆️

@odeimaiz odeimaiz changed the title WIP: Lock links when pipeline is running: frontend Lock links when pipeline is running: frontend Feb 7, 2022
@odeimaiz odeimaiz marked this pull request as ready for review February 7, 2022 15:01
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Collaborator

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go for it!

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! the backend part will follow shortly.

@odeimaiz odeimaiz merged commit f41ebfa into ITISFoundation:master Feb 8, 2022
@odeimaiz odeimaiz deleted the feature/read-only-link-while-running branch February 8, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants