Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Search filters #2804

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 8, 2022

What do these changes do?

Issue: Study/Template/Service cards were interacting with the search filters that didn't belong to their tab. This PR fixes that bug:
filtering

How to test

Checklist

@odeimaiz odeimaiz added this to the R.Schumann milestone Feb 8, 2022
@odeimaiz odeimaiz self-assigned this Feb 8, 2022
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🐛bugfix labels Feb 8, 2022
@codecov
Copy link

codecov bot commented Feb 8, 2022

Codecov Report

Merging #2804 (6807dba) into master (f47fc4c) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2804   +/-   ##
======================================
  Coverage    78.8%   78.9%           
======================================
  Files         670     670           
  Lines       27200   27200           
  Branches     2669    2669           
======================================
+ Hits        21454   21461    +7     
+ Misses       4990    4985    -5     
+ Partials      756     754    -2     
Flag Coverage Δ
integrationtests 65.9% <ø> (+<0.1%) ⬆️
unittests 74.4% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...simcore_service_webserver/projects/project_lock.py 94.7% <0.0%> (-5.3%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 86.4% <0.0%> (+0.5%) ⬆️
..._director_v2/modules/dynamic_sidecar/docker_api.py 87.2% <0.0%> (+0.5%) ⬆️
.../director/src/simcore_service_director/producer.py 63.5% <0.0%> (+0.6%) ⬆️
...car/src/simcore_service_dask_sidecar/dask_utils.py 91.7% <0.0%> (+1.0%) ⬆️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 95.8% <0.0%> (+1.1%) ⬆️

@odeimaiz odeimaiz marked this pull request as ready for review February 8, 2022 13:11
@odeimaiz odeimaiz changed the title WIP: Fix: Search filter Fix: Search filter Feb 8, 2022
@odeimaiz odeimaiz changed the title Fix: Search filter Search filter Feb 8, 2022
@odeimaiz odeimaiz changed the title Search filter Fix: Search filters Feb 8, 2022
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magical!

@odeimaiz odeimaiz merged commit 10b14ad into ITISFoundation:master Feb 8, 2022
@odeimaiz odeimaiz deleted the fix/search-filter branch February 8, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants