Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/disable Export and Duplicate #2820

Merged
merged 3 commits into from
Feb 11, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 11, 2022

What do these changes do?

Following #2814

Check statics from webserver to enable/disable Export and Duplicate.

The animation was paused in order to add the WEBSERVER_EXPORT variable and restart the webserver:
ExportDisabled

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz changed the title Feature/check export Enable/disable Export and Duplicate Feb 11, 2022
@odeimaiz odeimaiz self-assigned this Feb 11, 2022
@odeimaiz odeimaiz added the a:frontend issue affecting the front-end (area group) label Feb 11, 2022
@odeimaiz odeimaiz added this to the R.Schumann milestone Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #2820 (9099d13) into master (fffcb66) will increase coverage by 1.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2820     +/-   ##
========================================
+ Coverage    77.8%   78.9%   +1.0%     
========================================
  Files         670     670             
  Lines       27257   27257             
  Branches     3146    3146             
========================================
+ Hits        21225   21513    +288     
+ Misses       5283    4983    -300     
- Partials      749     761     +12     
Flag Coverage Δ
integrationtests 65.8% <ø> (+3.5%) ⬆️
unittests 74.4% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ce_webserver/resource_manager/websocket_manager.py 93.3% <0.0%> (-4.0%) ⬇️
.../director/src/simcore_service_director/producer.py 61.6% <0.0%> (-0.7%) ⬇️
...or_v2/models/schemas/dynamic_services/scheduler.py 97.0% <0.0%> (+2.9%) ⬆️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 86.4% <0.0%> (+3.5%) ⬆️
..._director_v2/modules/dynamic_sidecar/docker_api.py 87.2% <0.0%> (+7.2%) ⬆️
...rvice-library/src/servicelib/common_aiopg_utils.py 97.0% <0.0%> (+8.8%) ⬆️
...imcore_service_catalog/db/repositories/projects.py 54.1% <0.0%> (+12.5%) ⬆️
...c/simcore_service_catalog/core/background_tasks.py 81.9% <0.0%> (+13.8%) ⬆️
...es/dynamic_sidecar/docker_service_specs/sidecar.py 82.9% <0.0%> (+14.6%) ⬆️
...vice_director_v2/modules/dynamic_sidecar/errors.py 100.0% <0.0%> (+17.3%) ⬆️
... and 7 more

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 very nice

Copy link
Collaborator

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go go go!

@odeimaiz odeimaiz merged commit 5bfec5c into ITISFoundation:master Feb 11, 2022
@odeimaiz odeimaiz deleted the feature/check-export branch February 11, 2022 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants