Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: service catalog search filter #2821

Merged
merged 1 commit into from
Feb 11, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Feb 11, 2022

What do these changes do?

SC

Related issues

closes #2810

@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:🐛bugfix labels Feb 11, 2022
@odeimaiz odeimaiz added this to the R.Schumann milestone Feb 11, 2022
@odeimaiz odeimaiz self-assigned this Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #2821 (bc5a3c5) into master (a54c0ea) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2821     +/-   ##
========================================
- Coverage    78.9%   78.8%   -0.1%     
========================================
  Files         670     670             
  Lines       27257   27257             
  Branches     3146    3146             
========================================
- Hits        21507   21500      -7     
- Misses       4991    4993      +2     
- Partials      759     764      +5     
Flag Coverage Δ
integrationtests 65.8% <ø> (-0.1%) ⬇️
unittests 74.4% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 94.7% <0.0%> (-1.2%) ⬇️
...car/src/simcore_service_dask_sidecar/dask_utils.py 89.6% <0.0%> (-1.1%) ⬇️
...ore_service_director_v2/api/routes/computations.py 81.8% <0.0%> (-0.9%) ⬇️
...ce_webserver/resource_manager/garbage_collector.py 72.7% <0.0%> (-0.9%) ⬇️
.../director/src/simcore_service_director/producer.py 61.6% <0.0%> (-0.7%) ⬇️
...simcore_service_director_v2/modules/dask_client.py 83.2% <0.0%> (+1.2%) ⬆️

Copy link
Collaborator

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bravo!

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@odeimaiz odeimaiz merged commit fffcb66 into ITISFoundation:master Feb 11, 2022
@odeimaiz odeimaiz deleted the fix/service-catalog-filter branch February 11, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

search in catalog does not filter
3 participants