Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑️ hotfix GC first deploy #2899

Merged
merged 5 commits into from
Mar 17, 2022

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Mar 17, 2022

What do these changes do?

Following problems were detected

  1. 🐛 resulting hostname: "{{.Node.Hostname}}-{{.Service.Name}}-{{.Task.Slot}}" was too long.
    • swarm was not able to start the service which would constantly fail as container init caused: sethostname: invalid argument: unknown
    • was not detected during devel because every deploy adds a different prefix
    • FIX: shorten service name to ws-garbage-collector
  2. 🐛 garbage_collector could not load json-schema for project which is normally init by the projects plugin (which is off in this config)
    • was not detected during devel because the GC service was not tested under these conditions (notice that all tests consider all plugins ON). Noted for create webserver integration tests for different service config #2896.
    • FIX: Splits projects plugin setup functions such that the garbage_collector can init the parts it needs so it can safely use projects_api interface.
  3. added devops team as CODEOWNERS on all config files related with deployment

Related issue/s

How to test

  • Covered by CI

Checklist

…(ops adds deploy prefix)

service could not start because hostname was too long. Error message was

 container init caused: sethostname: invalid argument: unknown
@pcrespov pcrespov self-assigned this Mar 17, 2022
@pcrespov pcrespov added changelog:🐛bugfix a:webserver issue related to the webserver service labels Mar 17, 2022
@pcrespov pcrespov added this to the E.Shackleton milestone Mar 17, 2022
@pcrespov pcrespov requested a review from Surfict March 17, 2022 15:52
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

services/docker-compose.devel.yml Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #2899 (5b4aae7) into master (1dea3f5) will decrease coverage by 3.2%.
The diff coverage is 90.4%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2899     +/-   ##
========================================
- Coverage    79.3%   76.1%   -3.3%     
========================================
  Files         673     673             
  Lines       27624   27633      +9     
  Branches     3218    3220      +2     
========================================
- Hits        21928   21040    -888     
- Misses       4946    5899    +953     
+ Partials      750     694     -56     
Flag Coverage Δ
integrationtests 40.8% <71.4%> (-24.8%) ⬇️
unittests 74.9% <90.4%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mcore_service_webserver/projects/project_models.py 92.3% <84.6%> (-7.7%) ⬇️
...src/simcore_service_webserver/garbage_collector.py 100.0% <100.0%> (ø)
...r/src/simcore_service_webserver/projects/plugin.py 86.6% <100.0%> (+3.3%) ⬆️
.../simcore_service_webserver/projects/projects_db.py 93.6% <100.0%> (-0.3%) ⬇️
...imcore_service_webserver/exporter/export_import.py 35.7% <0.0%> (-59.6%) ⬇️
...re-sdk/src/simcore_sdk/node_ports/serialization.py 25.0% <0.0%> (-57.4%) ⬇️
...vice_webserver/exporter/formatters/formatter_v2.py 31.9% <0.0%> (-56.4%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 38.8% <0.0%> (-54.9%) ⬇️
...vice_webserver/exporter/formatters/formatter_v1.py 24.5% <0.0%> (-54.2%) ⬇️
...c/simcore_service_webserver/users_to_groups_api.py 46.1% <0.0%> (-53.9%) ⬇️
... and 48 more

@pcrespov pcrespov merged commit 09c200d into ITISFoundation:master Mar 17, 2022
@pcrespov pcrespov deleted the maintenance/devops-gc branch March 17, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants