-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♻️ Maintenance: reduce number of webserver CI jobs #2900
♻️ Maintenance: reduce number of webserver CI jobs #2900
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2900 +/- ##
=========================================
- Coverage 79.4% 66.9% -12.5%
=========================================
Files 673 564 -109
Lines 27649 22302 -5347
Branches 3222 2680 -542
=========================================
- Hits 21954 14933 -7021
- Misses 4943 6877 +1934
+ Partials 752 492 -260
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what criteria did you use for the new grouping? Just the timings? take into account that if the grouping is by "topic" ( e.g. by plugin) we could take advantage of common fixtures.
I guess this iteration having groups named as 01, 05 and 10 would be fine, but it would be nice to make it a bit more human readable
1d54d76
to
0a78c91
Compare
0a78c91
to
fa76095
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 I would just make sure that in the future the number just increases. It is weird to see 1,5,9,10. I'd prefer 1,2,3,4
…:sanderegg/osparc-simcore into maintenance/reduce_web_server_unit_tests
What do these changes do?
This PR aims to make the CI runs a bit more reasonable by:
BEFORE:
AFTER:
Related issue/s
How to test
Checklist