Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Maintenance: reduce number of webserver CI jobs #2900

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Mar 17, 2022

What do these changes do?

This PR aims to make the CI runs a bit more reasonable by:

  • reducing the amount of jobs (each job is done by a runner)
  • the webserver has currently 11 jobs = 11 runners in use

BEFORE:

01 - 1m18
02 - 1m59
03 - 52s
04 - 1m03
05 - 2m25
06 - 3m23
07 - 1m15
08 - 58s
09 - 2m46
10 - 3m09

AFTER:

01: 2m08+3m29 (prior isolated + fuse of ~01-02-03-04)
09: 5m43 (prior ~07-08-09)
10: 3m30 (more or less kept)

Related issue/s

How to test

  • Covered by CI

Checklist

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #2900 (b6bff67) into master (b259fdc) will decrease coverage by 12.4%.
The diff coverage is 0.0%.

❗ Current head b6bff67 differs from pull request most recent head cd0544a. Consider uploading reports for the commit cd0544a to get more accurate results

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2900      +/-   ##
=========================================
- Coverage    79.4%   66.9%   -12.5%     
=========================================
  Files         673     564     -109     
  Lines       27649   22302    -5347     
  Branches     3222    2680     -542     
=========================================
- Hits        21954   14933    -7021     
- Misses       4943    6877    +1934     
+ Partials      752     492     -260     
Flag Coverage Δ
integrationtests ?
unittests 66.9% <0.0%> (-8.0%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erver/src/simcore_service_webserver/login/utils.py 52.2% <ø> (ø)
...re_service_webserver/projects/projects_handlers.py 49.8% <0.0%> (-31.4%) ⬇️
...service_webserver/projects/_project_models_rest.py 0.0% <0.0%> (-100.0%) ⬇️
...erver/src/simcore_service_webserver/rest_models.py 0.0% <0.0%> (-92.7%) ⬇️
...rc/simcore_service_webserver/computation_config.py 0.0% <0.0%> (-88.9%) ⬇️
...mcore_service_webserver/projects/nodes_handlers.py 0.0% <0.0%> (-71.5%) ⬇️
...erver/src/simcore_service_webserver/clusters/db.py 19.2% <0.0%> (-68.9%) ⬇️
...ce_webserver/studies_dispatcher/_studies_access.py 22.6% <0.0%> (-68.1%) ⬇️
...rc/simcore_service_webserver/exporter/archiving.py 29.4% <0.0%> (-66.7%) ⬇️
...simcore_service_webserver/director/director_api.py 0.0% <0.0%> (-65.9%) ⬇️
... and 217 more

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what criteria did you use for the new grouping? Just the timings? take into account that if the grouping is by "topic" ( e.g. by plugin) we could take advantage of common fixtures.

I guess this iteration having groups named as 01, 05 and 10 would be fine, but it would be nice to make it a bit more human readable

@sanderegg sanderegg force-pushed the maintenance/reduce_web_server_unit_tests branch from 1d54d76 to 0a78c91 Compare March 17, 2022 20:54
@sanderegg sanderegg force-pushed the maintenance/reduce_web_server_unit_tests branch from 0a78c91 to fa76095 Compare March 18, 2022 06:57
Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I would just make sure that in the future the number just increases. It is weird to see 1,5,9,10. I'd prefer 1,2,3,4

@sanderegg sanderegg merged commit ed5e555 into ITISFoundation:master Mar 18, 2022
@sanderegg sanderegg deleted the maintenance/reduce_web_server_unit_tests branch March 18, 2022 08:39
sanderegg added a commit that referenced this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants