Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚑️ GC needs dependency to login storage #2904

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Mar 17, 2022

What do these changes do?

Follows up fixes in #2901 to get GC working in master-deploy for the first time.

Related issue/s

How to test

  • Covered by CI

Checklist

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #2904 (98785ac) into master (d891912) will decrease coverage by 0.0%.
The diff coverage is 83.3%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2904     +/-   ##
========================================
- Coverage    79.4%   79.4%   -0.1%     
========================================
  Files         673     673             
  Lines       27642   27646      +4     
  Branches     3221    3221             
========================================
- Hits        21955   21952      -3     
- Misses       4941    4943      +2     
- Partials      746     751      +5     
Flag Coverage Δ
integrationtests 65.7% <83.3%> (-0.1%) ⬇️
unittests 74.9% <83.3%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rver/src/simcore_service_webserver/login/plugin.py 86.9% <80.0%> (-4.0%) ⬇️
...src/simcore_service_webserver/garbage_collector.py 100.0% <100.0%> (ø)
...simcore_service_webserver/projects/project_lock.py 94.7% <0.0%> (-5.3%) ⬇️
.../director/src/simcore_service_director/producer.py 61.6% <0.0%> (-1.1%) ⬇️
...ervices/storage/src/simcore_service_storage/dsm.py 73.4% <0.0%> (-0.7%) ⬇️
...c/simcore_service_catalog/core/background_tasks.py 68.4% <0.0%> (+2.1%) ⬆️
.../simcore_service_catalog/services/access_rights.py 81.2% <0.0%> (+2.5%) ⬆️

@pcrespov pcrespov merged commit 7925a64 into ITISFoundation:master Mar 17, 2022
@pcrespov pcrespov deleted the maintenance/fix-gc-3 branch March 17, 2022 23:18
@sanderegg sanderegg added this to the E.Shackleton milestone Mar 31, 2022
@pcrespov pcrespov self-assigned this Apr 3, 2022
@pcrespov pcrespov added a:webserver issue related to the webserver service changelog:🐛bugfix labels Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants