Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Maintenance/week 12 test, tooling, libs/packages #2916

Merged
merged 39 commits into from
Mar 30, 2022

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Mar 22, 2022

What do these changes do?

⚠️ Important changes:

  • unpinned tomli
  • unpinned idna
  • unpinned jsonschema from webserver
  • unpinned openapi-schema-validator from webserver

1/2 Changes to libraries (only updated libraries are included)

  • #packages before: 125
  • #packages after : 103
# name before after upgrade count
1 aio-pika 6.8.0, 6.8.2 7.1.2 MAJOR 2
2 aioboto3 9.3.1 9.4.0 minor 1
3 aiobotocore 1.4.1, 2.1.0 2.2.0,2.1.2 minor 2
4 aiodebug 1.1.2 2.3.0 MAJOR 1
5 aiohttp-jinja2 1.4.2 1.5 minor 1
6 aiohttp-session 2.9.0 2.11.0 minor 1
7 aiohttp-swagger 1.0.15 1.0.16 2
8 aioitertools 0.8.0 0.10.0 minor 2
9 aioredlock 0.7.1 0.7.3 1
10 aioresponses 0.7.2 0.7.3 1
11 aiormq 3.3.1 6.2.3 MAJOR 2
12 alembic 1.7.4, 1.7.6, 1.7.5 1.7.7 11
13 anyio 3.4.0 🗑️ removed 1
14 argcomplete 1.12.3 🗑️ removed 1
15 astroid 2.9.0, 2.9.3 2.11.2 minor 15
16 async-asgi-testclient 1.4.9, 1.4.7 1.4.10 2
17 asyncpg 0.23.0 0.25.0 minor 1
18 attrs 21.4.0 🗑️ removed 1
19 backports-entry-points-selectable 1.1.1 🗑️ removed 3
20 black 21.12 22.1.0 MAJOR 4
21 botocore 1.20.106 1.24.21 minor 1
22 certifi 2021.10.8, 2021.5.30 2021.10.8 3
23 cffi 1.14.5 1.15.0 minor 2
24 chardet 4.0.0 🗑️ removed 1
25 charset-normalizer 2.0.11 2.0.12 16
26 click 8.0.1, 8.0.3 8.0.4 20
27 coverage 6.1.2, 6.3.1 6.3.2 16
28 cryptography 36.0.1, 3.4.7, 36.0.0 36.0.2 10
29 dask 2022.1.1 2022.3.0 minor 1
30 datamodel-code-generator 0.11.14 🗑️ removed 1
31 distlib 0.3.3 0.3.4 3
32 distributed 2022.1.1 2022.3.0 minor 1
33 distro 1.6.0 1.7.0 minor 6
34 dnspython 2.2.0, 2.1.0 2.2.1 9
35 email-validator 1.1.3 🗑️ removed 1
36 faker 12.3.0, 9.8.3, 12.1.0, 13.3.0 13.3.3 14
37 fastapi 0.74.1, 0.73.0 0.75.0 minor 2
38 filelock 3.4.0, 3.4.2 3.6.0 minor 16
39 fsspec 2022.1.0 2022.2.0 minor 1
40 genson 1.2.2 🗑️ removed 1
41 h11 0.12.0 🗑️ removed 1
42 httpcore 0.14.3 🗑️ removed 1
43 httpx 0.21.3 🗑️ removed 1
44 hypothesis 6.39.3 6.39.6 1
45 identify 2.4.11, 2.4.3, 2.4.0, 2.4.9, 2.4.10 2.4.12 17
46 idna 2.10 3.3 MAJOR 23
47 importlib-metadata 4.10.1, 4.10.0, 4.8.1, 4.11.2 4.11.3 11
48 importlib-resources 5.3.0, 5.4.0 5.6.0 minor 15
49 inflect 5.3.0 🗑️ removed 1
50 isodate 0.6.0, 0.6.1 0.6.1 3
51 itsdangerous 2.1.0 2.1.2 1
52 jinja2 3.0.3, 2.11.3 3.1.1 minor 6
53 jmespath 0.10.0 1.0.0 MAJOR 1
54 jsondiff 1.3.0 1.3.1 1
55 jsonschema 4.4.0, 3.2.0 4.4.0 3
56 lazy-object-proxy 1.6.0 1.7.1 minor 1
57 mako 1.1.6, 1.1.5 1.2.0 minor 11
58 markupsafe 2.0.1, 1.1.1, 2.1.0 2.1.1 14
59 mccabe 0.6.1 0.7.0 minor 15
60 multidict 5.1.0 6.0.2 MAJOR 4
61 mypy 0.931 0.942 minor 1
62 numpy 1.21.4 1.22.3 minor 2
63 openapi-schema-validator 0.1.6, 0.1.5 0.2.3 minor 4
64 openapi-spec-validator 0.3.1 0.4.0 minor 4
65 openpyxl 3.0.7 3.0.9 1
66 orjson 3.5.3 3.6.7 minor 1
67 pamqp 2.3.0 3.1.0 MAJOR 2
68 pandas 1.3.4 1.4.1 minor 1
69 paramiko 2.8.0, 2.9.2 2.10.3 minor 7
70 platformdirs 2.4.0, 2.5.0 2.5.1 29
71 prance 0.21.8.0 🗑️ removed 1
72 pre-commit 2.16.0, 2.15.0 2.17.0 minor 4
73 prometheus-client 0.11.0, 0.12.0 0.13.1 minor 2
74 psycopg2-binary 2.9.1 2.9.3 3
75 pycparser 2.20 2.21 minor 2
76 pydantic 1.9.0 🗑️ removed 1
77 pylint 2.12.1, 2.12.2 2.13.2 minor 15
78 pynacl 1.4.0 1.5.0 minor 3
79 pyparsing 3.0.6 3.0.7 1
80 pyrsistent 0.18.0, 0.18.1 0.18.1 5
81 pysnooper 0.5.0 🗑️ removed 1
82 pytest 7.0.0, 6.2.5, 7.0.1 7.1.1 minor 20
83 pytest-asyncio 0.18.0, 0.18.1 0.18.3 17
84 pytest-docker 0.10.3 0.11.0 minor 7
85 pytest-forked 1.3.0 1.4.0 minor 1
86 pytest-mock 3.6.1 3.7.0 minor 3
87 pytest-runner 5.3.1 6.0.0 MAJOR 14
88 pytest-xdist 2.4.0 2.5.0 minor 1
89 python-dotenv 0.19.2 0.20.0 minor 10
90 python-magic 0.4.24 0.4.25 1
91 pytz 2021.3 2022.1 MAJOR 1
92 pyyaml 5.4.1 6.0 MAJOR 2
93 redis 3.5.3 4.2.0 MAJOR 1
94 regex 2021.11.10 🗑️ removed 1
95 requests 2.27.1, 2.26.0 2.27.1 3
96 respx 0.19.1 0.19.2 1
97 rfc3986 1.5.0 🗑️ removed 1
98 ruamel-yaml 0.17.17 🗑️ removed 1
99 ruamel-yaml-clib 0.2.6 🗑️ removed 1
100 s3transfer 0.5.0 0.5.2 1
101 semantic-version 2.8.5 2.9.0 minor 2
102 semver 2.13.0 🗑️ removed 1
103 six 1.16.0 🗑️ removed 1
104 sniffio 1.2.0 🗑️ removed 1
105 sqlalchemy 1.4.31 1.4.32 13
106 text-unidecode 1.3 🗑️ removed 3
107 toml 0.10.2 🗑️ removed 14
108 tomli 1.2.2, 1.2.3 2.0.1 MAJOR 37
109 tqdm 4.62.3, 4.63.0, 4.61.1 4.63.1 4
110 types-aiofiles 0.8.3 0.8.5 1
111 types-pyyaml 6.0.4 6.0.5 1
112 typing-extensions 3.10.0.2, 4.0.1 4.1.1 minor 34
113 ujson 4.0.2 5.1.0 MAJOR 2
114 urllib3 1.26.8, 1.26.7 1.26.9 18
115 virtualenv 20.13.2, 20.13.0, 20.10.0, 20.13.1 20.14.0 minor 17
116 watchdog 2.1.6 2.1.7 7
117 watchgod 0.7 0.8.1 minor 1
118 websocket-client 1.2.3 1.3.1 minor 3
119 websockets 10.1 10.2 minor 1
120 werkzeug 2.0.2, 2.0.1 2.0.3 2
121 wheel 0.37.0 0.37.1 3
122 wrapt 1.13.3, 1.12.1 1.14.0 minor 15
123 yarl 1.5.1 1.7.2 minor 2
124 zict 2.0.0 2.1.0 minor 1
125 zipp 3.6.0, 3.7.0 3.7.0 2

2/2 Repo wide overview of libraries

  • #reqs files parsed: 57
# name versions-base versions-test versions-tool
1 aio-pika 6.8.0, 7.1.2 6.8.0, 7.1.2
2 aioboto3 9.4.0
3 aiobotocore 2.2.0 2.1.2
4 aiocache 0.11.1
5 aiodebug 1.1.2, 2.3.0 2.3.0
6 aiodocker 0.19.1, 0.21.0 0.21.0
7 aiofiles 0.5.0, 0.8.0 0.8.0
8 aiohttp 3.8.1 3.8.1
9 aiohttp-jinja2 1.5
10 aiohttp-security 0.4.0
11 aiohttp-session 2.11.0
12 aiohttp-swagger 1.0.16
13 aioitertools 0.10.0 0.10.0
14 aiopg 1.3.3 1.3.3
15 aioredis 1.3.1 1.3.1
16 aioredlock 0.7.3
17 aioresponses 0.7.3
18 aiormq 3.3.1, 6.2.3 3.3.1, 6.2.3
19 aiosignal 1.2.0 1.2.0
20 aiosmtplib 1.1.6
21 aiozipkin 1.1.1
22 alembic 1.7.4, 1.7.5, 1.7.7 1.7.4, 1.7.5, 1.7.7
23 anyio 3.2.0, 3.2.1, 3.3.4, 3.5.0 3.2.1, 3.5.0
24 argon2-cffi 20.1.0
25 asgi-lifespan 1.0.1
26 asgiref 3.4.1, 3.5.0
27 astroid 2.11.2 2.11.2
28 async-asgi-testclient 1.4.10
29 async-generator 1.10
30 async-timeout 4.0.1, 4.0.2 4.0.1, 4.0.2
31 asyncpg 0.25.0
32 attrs 20.2.0, 20.3.0, 21.4.0 20.2.0, 20.3.0, 21.4.0
33 bcrypt 3.2.0 3.2.0
34 black 22.1.0
35 bleach 3.3.0
36 blosc 1.10.6
37 bokeh 2.4.2 2.4.2
38 boto3 1.17.104 1.20.24
39 botocore 1.20.104, 1.24.21 1.23.24
40 bump2version 1.0.1
41 certifi 2020.12.5, 2021.5.30, 2021.10.8 2020.12.5, 2021.5.30, 2021.10.8
42 cffi 1.14.5, 1.15.0 1.14.5, 1.15.0
43 cfgv 3.3.1
44 change-case 0.5.2 0.5.2
45 chardet 3.0.4, 4.0.0 3.0.4, 4.0.0
46 charset-normalizer 2.0.6, 2.0.7, 2.0.10, 2.0.12 2.0.6, 2.0.10, 2.0.12
47 click 8.0.3, 8.0.4 8.0.3, 8.0.4 8.0.3, 8.0.4
48 cloudpickle 2.0.0
49 codecov 2.1.12
50 colorlog 6.6.0
51 configparser 5.0.2
52 coverage 6.3.2
53 coveralls 3.3.1
54 cryptography 3.4.7, 36.0.2 36.0.2
55 cytoolz 0.11.0
56 dask 2022.2.1, 2022.3.0
57 dask-gateway 0.9.0
58 dask-gateway-server 0.9.0
59 decorator 4.4.2
60 defusedxml 0.7.1
61 deprecated 1.2.12 1.2.13
62 dill 0.3.4 0.3.4
63 distlib 0.3.4
64 distributed 2022.2.1, 2022.3.0
65 distro 1.5.0 1.7.0
66 dnspython 2.0.0, 2.1.0, 2.2.1 2.2.1
67 docker 5.0.2, 5.0.3 5.0.3
68 docker-compose 1.29.1 1.29.1
69 dockerpty 0.4.1 0.4.1
70 docopt 0.6.2 0.6.2
71 ecdsa 0.14.1
72 email-validator 1.1.1, 1.1.2, 1.1.3 1.1.3
73 entrypoints 0.3
74 et-xmlfile 1.1.0
75 execnet 1.9.0
76 expiringdict 1.2.1
77 faker 13.3.3
78 fastapi 0.71.0, 0.75.0
79 fastapi-contrib 0.2.11
80 fastapi-pagination 0.8.0
81 filelock 3.6.0
82 flaky 3.7.0
83 frozenlist 1.2.0, 1.3.0 1.2.0, 1.3.0
84 fsspec 2022.2.0
85 future 0.18.2
86 futures 3.1.1
87 greenlet 1.1.2 1.1.2
88 gunicorn 20.1.0
89 h11 0.12.0 0.12.0
90 h2 3.2.0
91 heapdict 1.0.1
92 hiredis 2.0.0 2.0.0
93 hpack 3.0.0
94 httpcore 0.14.4, 0.14.7 0.14.4, 0.14.7
95 httptools 0.2.0, 0.3.0
96 httpx 0.21.3, 0.22.0 0.21.3, 0.22.0
97 hyperframe 5.2.0
98 hypothesis 6.39.6
99 icdiff 2.0.4
100 identify 2.4.12
101 idna 2.10, 3.3 2.10, 3.3
102 importlib-metadata 4.8.1, 4.11.3 4.8.1, 4.11.3
103 importlib-resources 5.3.0, 5.6.0 5.3.0, 5.6.0
104 iniconfig 1.1.1 1.1.1
105 inotify 0.2.10
106 ipython-genutils 0.2.0
107 isodate 0.6.1
108 isort 5.10.1 5.10.1
109 itsdangerous 1.1.0, 2.1.2
110 jaeger-client 4.8.0
111 jinja-app-loader 1.0.2
112 jinja2 2.11.3, 3.1.1 2.11.3 3.1.1
113 jmespath 0.10.0, 1.0.0 0.10.0
114 json2html 1.3.0
115 jsondiff 1.3.1
116 jsonschema 3.2.0, 4.4.0 3.2.0, 4.4.0
117 jupyter-client 6.1.12
118 jupyter-core 4.7.1
119 jupyter-server 1.8.0
120 jupyter-server-proxy 3.2.1
121 jupyterlab-pygments 0.1.2
122 lazy-object-proxy 1.4.3 1.4.3, 1.7.1 1.7.1
123 locket 0.2.1
124 lz4 4.0.0
125 mako 1.1.5, 1.2.0 1.1.5, 1.2.0
126 markupsafe 1.1.1, 2.0.1, 2.1.1 1.1.1, 2.0.1, 2.1.1 2.1.1
127 mccabe 0.7.0 0.7.0
128 minio 7.0.4 7.0.4
129 mistune 0.8.4
130 msgpack 1.0.2, 1.0.3
131 multidict 5.1.0, 5.2.0, 6.0.2 5.1.0, 5.2.0, 6.0.2
132 mypy 0.942
133 mypy-extensions 0.4.3
134 nbclient 0.5.3
135 nbconvert 6.0.7
136 nbformat 5.1.3
137 nest-asyncio 1.5.1
138 networkx 2.5.1
139 nodeenv 1.6.0
140 nose 1.3.7
141 numpy 1.22.3 1.22.3
142 openapi-core 0.12.0
143 openapi-schema-validator 0.2.3 0.2.3
144 openapi-spec-validator 0.4.0 0.4.0
145 openpyxl 3.0.9
146 opentracing 2.4.0
147 orjson 3.4.8, 3.5.4, 3.6.7
148 packaging 20.4, 20.9, 21.0, 21.3 20.4, 20.9, 21.0, 21.3
149 pamqp 2.3.0, 3.1.0 2.3.0, 3.1.0
150 pandas 1.2.4 1.4.1
151 pandocfilters 1.4.3
152 paramiko 2.7.2 2.10.3
153 parfive 1.5.1
154 partd 1.2.0
155 passlib 1.7.4 1.7.4
156 pathspec 0.9.0
157 pennsieve 6.1.2
158 pep517 0.12.0
159 pillow 9.0.1 9.0.1
160 pint 0.18 0.18
161 pip-tools 6.5.1
162 platformdirs 2.5.1 2.5.1
163 pluggy 1.0.0 1.0.0
164 pprintpp 0.4.0
165 pre-commit 2.17.0
166 prometheus-client 0.11.0, 0.13.1
167 protobuf 3.17.3
168 psutil 5.8.0, 5.9.0
169 psycopg2-binary 2.8.6, 2.9.1, 2.9.2, 2.9.3 2.8.6, 2.9.2, 2.9.3
170 ptvsd 4.3.2 4.3.2
171 ptyprocess 0.7.0
172 py 1.11.0 1.11.0
173 py-cpuinfo 8.0.0
174 pyasn1 0.4.8
175 pycparser 2.20, 2.21 2.20, 2.21
176 pydantic 1.9.0 1.9.0
177 pyftpdlib 1.5.6
178 pygments 2.9.0
179 pyinstrument 3.4.2, 4.0.3, 4.1.1 4.1.1
180 pyinstrument-cext 0.2.4
181 pylint 2.13.2 2.13.2
182 pynacl 1.4.0 1.5.0
183 pyopenssl 22.0.0
184 pyparsing 2.4.7, 3.0.7 2.4.7, 3.0.7
185 pyrsistent 0.17.3, 0.18.0, 0.18.1 0.18.1
186 pytest 7.1.1 7.1.1
187 pytest-aiohttp 1.0.4
188 pytest-asyncio 0.18.3
189 pytest-benchmark 3.4.1
190 pytest-cov 3.0.0
191 pytest-docker 0.11.0
192 pytest-forked 1.4.0
193 pytest-icdiff 0.5
194 pytest-instafail 0.4.2
195 pytest-lazy-fixture 0.6.3
196 pytest-localftpserver 1.1.3
197 pytest-mock 3.7.0
198 pytest-runner 6.0.0
199 pytest-sugar 0.9.4
200 pytest-xdist 2.5.0
201 python-dateutil 2.8.1, 2.8.2 2.8.1, 2.8.2
202 python-dotenv 0.15.0, 0.18.0, 0.19.0, 0.20.0 0.15.0, 0.18.0, 0.19.0, 0.20.0
203 python-engineio 3.14.2
204 python-jose 3.2.0
205 python-magic 0.4.25
206 python-multipart 0.0.5
207 python-socketio 4.6.1
208 pytz 2020.1, 2021.1 2022.1
209 pyyaml 5.4.1, 6.0 5.4.1, 6.0 5.4.1, 6.0
210 pyzmq 22.1.0
211 redis 4.2.0
212 requests 2.25.1, 2.26.0, 2.27.1 2.25.1, 2.26.0, 2.27.1
213 respx 0.19.2
214 rfc3986 1.4.0, 1.5.0 1.4.0, 1.5.0
215 rsa 4.0
216 s3transfer 0.4.2 0.5.2
217 semantic-version 2.9.0
218 semver 2.13.0
219 send2trash 1.7.1
220 setproctitle 1.2.2
221 simpervisor 0.4
222 six 1.15.0, 1.16.0 1.15.0, 1.16.0 1.15.0, 1.16.0
223 sniffio 1.2.0 1.2.0
224 sortedcontainers 2.4.0 2.4.0
225 sqlalchemy 1.4.31, 1.4.32 1.4.31, 1.4.32
226 starlette 0.17.1
227 strict-rfc3339 0.7
228 tblib 1.7.0
229 tenacity 6.3.1, 7.0.0, 8.0.1 8.0.1
230 termcolor 1.1.0
231 terminado 0.10.1
232 testpath 0.5.0
233 texttable 1.6.3 1.6.4
234 threadloop 1.0.2
235 thrift 0.13.0, 0.15.0
236 toml 0.10.2
237 tomli 2.0.1 2.0.1 2.0.1
238 toolz 0.11.1, 0.11.2
239 tornado 6.1 6.1
240 tqdm 4.62.3, 4.63.1 4.63.1
241 traitlets 5.0.5 5.1.1
242 typer 0.4.0 0.4.0 0.4.0
243 types-aiofiles 0.8.5
244 types-pkg-resources 0.1.3
245 types-pyyaml 6.0.5
246 typing-extensions 3.10.0.2, 4.1.1 3.10.0.2, 4.1.1 3.10.0.2, 4.1.1
247 ujson 4.0.2, 4.3.0, 5.1.0
248 urllib3 1.26.6, 1.26.7, 1.26.9 1.26.6, 1.26.7, 1.26.9
249 uvicorn 0.15.0, 0.17.0
250 uvloop 0.14.0, 0.15.2, 0.16.0
251 virtualenv 20.14.0
252 watchdog 2.1.5 2.1.7
253 watchgod 0.6, 0.7, 0.8.1
254 webencodings 0.5.1
255 websocket-client 0.59.0, 1.1.0, 1.3.1 0.59.0, 1.3.1
256 websockets 10.1, 10.2 10.2
257 werkzeug 2.0.3
258 wheel 0.37.1
259 wrapt 1.12.1, 1.14.0 1.12.1, 1.14.0 1.14.0
260 yarl 1.5.1, 1.6.3, 1.7.2 1.5.1, 1.6.3, 1.7.2
261 zict 2.0.0, 2.1.0
262 zipp 3.6.0, 3.7.0 3.6.0, 3.7.0

Related issue/s

How to test

Checklist

  • Unit tests for the changes exist
  • Runs in the swarm

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #2916 (09426f7) into master (7fcb113) will decrease coverage by 0.0%.
The diff coverage is 66.6%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #2916     +/-   ##
========================================
- Coverage    79.5%   79.5%   -0.1%     
========================================
  Files         677     677             
  Lines       28231   28230      -1     
  Branches     3282    3643    +361     
========================================
- Hits        22469   22461      -8     
- Misses       4995    5002      +7     
  Partials      767     767             
Flag Coverage Δ
integrationtests 65.6% <25.0%> (-0.1%) ⬇️
unittests 75.1% <66.6%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...catalog/src/simcore_service_catalog/core/events.py 90.0% <ø> (ø)
...er/src/simcore_service_webserver/login/handlers.py 88.2% <0.0%> (ø)
...imcore_service_webserver/meta_modeling_handlers.py 81.2% <ø> (-0.2%) ⬇️
...ervices/storage/src/simcore_service_storage/dsm.py 73.4% <100.0%> (-0.1%) ⬇️
...mcore_service_webserver/login/api_keys_handlers.py 92.7% <100.0%> (+0.1%) ⬆️
...rvice-library/src/servicelib/common_aiopg_utils.py 88.2% <0.0%> (-8.9%) ⬇️
...rvice_datcore_adapter/utils/requests_decorators.py 71.0% <0.0%> (-7.9%) ⬇️
...ce_webserver/resource_manager/websocket_manager.py 93.5% <0.0%> (-3.9%) ⬇️
.../simcore_service_catalog/db/repositories/groups.py 70.2% <0.0%> (-2.8%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 94.4% <0.0%> (-1.2%) ⬇️
... and 8 more

@GitHK GitHK changed the title ⬆️ Dependency upgrades ⬆️ Maintenance/week 12 test, tooling, libs/packages Mar 23, 2022
api/tests/requirements.txt Outdated Show resolved Hide resolved
packages/service-library/requirements/_aiohttp.txt Outdated Show resolved Hide resolved
requirements/constraints.txt Outdated Show resolved Hide resolved
@pcrespov pcrespov added this to the E.Shackleton milestone Mar 24, 2022
Copy link
Collaborator

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the most beautiful thing I've ever seen

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just revert the flaky test that is not anymore flaky.

Also I am not sure that table is very useful in the way it is at the moment. like httpx removed ok... but that's not true.

@pcrespov
Copy link
Member

@GitHK FYI code ownership is defined in CODEOWNERS.

  • @KZzizzle was added because you change requirements in service-integration
  • @mguidon was added because you change requirements in storage

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also I am not sure that table is very useful in the way it is at the moment. like httpx removed ok... but that's not true.

@GitHK please make sure the table makes sense!

@GitHK
Copy link
Contributor Author

GitHK commented Mar 29, 2022

@GitHK FYI code ownership is defined in CODEOWNERS.

  • @KZzizzle was added because you change requirements in service-integration
  • @mguidon was added because you change requirements in storage

So this must be correct at this point.

@GitHK
Copy link
Contributor Author

GitHK commented Mar 29, 2022

@sanderegg @pcrespov the way the table is generated is wrong. The diff is done only for updated packages. We should generate the table differently. Will leave a note for the next iteration on how to fix it.

@pcrespov
Copy link
Member

@sanderegg @pcrespov the way the table is generated is wrong. The diff is done only for updated packages. We should generate the table differently. Will leave a note for the next iteration on how to fix it.

My note was to make sure that the table has the correct results.

There are two tables possible. The first accounts for the changes and the second shows the current state of the repo

@GitHK
Copy link
Contributor Author

GitHK commented Mar 29, 2022

@sanderegg @pcrespov the way the table is generated is wrong. The diff is done only for updated packages. We should generate the table differently. Will leave a note for the next iteration on how to fix it.

My note was to make sure that the table has the correct results.

There are two tables possible. The first accounts for the changes and the second shows the current state of the repo

@sanderegg I've changed a bit the wording of the generated tables. Pleas let me know if it reads better now.

@sanderegg
Copy link
Member

@GitHK I don't understand what changed in the table. but the skipped tests are unskipped so I'm happy.

@GitHK
Copy link
Contributor Author

GitHK commented Mar 29, 2022

@GitHK I don't understand what changed in the table. but the skipped tests are unskipped so I'm happy.

Nothing changed in the tables. They are a they should be. Just the titles are different and should reflect better what information they are trying to provide:

  • 1/2 will display a diff of before and after the packages were updated, but only for the changes (it uses a git diff to compute this)
  • 2/2 does a repo wide summary of the current state of the packages

With this in mind I am opened for better names

@sanderegg
Copy link
Member

@GitHK , @pcrespov
to be honnest the problem with the table is not the naming. it's just that I don't see a huge benefit at the moment. There are so many entries, that I may be tempted to say that everything was changed. I think the most interesting table is the library updates... but this is also too much. I took httpx as an example. it says "removed" which I guess is the case in one package or maybe even a service right? Maybe it would be simpler to just mention the updates and downgrades if any.

@pcrespov
Copy link
Member

@GitHK , @pcrespov to be honnest the problem with the table is not the naming. it's just that I don't see a huge benefit at the moment. There are so many entries, that I may be tempted to say that everything was changed. I think the most interesting table is the library updates... but this is also too much.

The tables are work in progress and can definitively be improved. In any case, I think it brings already far more information that we had before. That said, I think it would be better if we explain offline what is the purpose of the info in the tables and where do we plan to go .

I took httpx as an example. it says "removed" which I guess is the case in one package or maybe even a service right? Maybe it would be simpler to just mention the updates and downgrades if any.

This should be interpreted as follows: this PR removes a dependency to httpx in one of the packages (as referred in the last column). Then, the next table shows all libraries repo-wide. You can then identify (entry 96) that two version of httpx are still in use in both base and test configurations.

IMO combining the info of both tables provide meaningful information. But I also agree that it is a lot of information and we could compact it a bit more.

@GitHK GitHK merged commit 1b903e9 into ITISFoundation:master Mar 30, 2022
@GitHK GitHK deleted the updates-mar-2022 branch March 30, 2022 06:45
@pcrespov pcrespov added t:maintenance Some planned maintenance work a:storage issue related to storage service dependencies Pull requests that update a dependency file and removed a:storage issue related to storage service labels Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants