(⚠️ devops) 🐛 Adding missing custom constraints

[GitHK]

(⚠️ devops)

On each deployment a new env var DIRECTOR_V2_SERVICES_CUSTOM_CONSTRAINTS should be defined on director-v2. The value should be taken from the DIRECTOR_SERVICES_CUSTOM_CONSTRAINTS in director and formatted to a json list. Example: from one==yes -> ["one==yes"]

What do these changes do?

• dynamic-sidecar new takes into consideration custom placement constraints
• added image name to dynamic-sidecar labels to make searching for services simpler
• if director-v2 cannot contact the dynamic-sidecar to save the state, it will no longer remove the dynamic-sidecar, giving the user an opportunity to save the state
• added utility scripts to dynamic-sidecar for saving states and pushing output ports when ssh into the container

Related issue/s

How to test

Checklist

[codecov]

Codecov Report

Merging #3017 (4fa1364) into master (d851b99) will decrease coverage by 0.0%.
The diff coverage is 80.0%.

@@           Coverage Diff            @@
##           master   #3017     +/-   ##
========================================
- Coverage    79.7%   79.7%   -0.1%     
========================================
  Files         693     693             
  Lines       29049   29052      +3     
  Branches     3745    3745             
========================================
+ Hits        23154   23155      +1     
  Misses       5062    5062             
- Partials      833     835      +2     

Flag	Coverage Δ
integrationtests	65.8% <80.0%> (-0.1%)	⬇️
unittests	75.5% <80.0%> (+<0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...es/dynamic_sidecar/docker_service_specs/sidecar.py	78.5% <ø> (ø)
...tor_v2/modules/dynamic_sidecar/scheduler/events.py	92.2% <0.0%> (-1.7%)	⬇️
...2/src/simcore_service_director_v2/core/settings.py	98.7% <100.0%> (+<0.1%)	⬆️
...mcore_service_webserver/garbage_collector_utils.py	79.4% <0.0%> (-3.0%)	⬇️
..._director_v2/modules/dynamic_sidecar/client_api.py	77.3% <0.0%> (-1.1%)	⬇️
.../director/src/simcore_service_director/producer.py	62.3% <0.0%> (+0.6%)	⬆️
...c/simcore_service_catalog/core/background_tasks.py	68.4% <0.0%> (+2.1%)	⬆️

[sanderegg]

great! thanks!

[sanderegg]

Q: did you try putting more than one constraint?

[GitHK]

I've added a regex and made it singular, only one constraint is accepted.

[sanderegg]

well actually it might cool to put several ones...

[pcrespov]

Here is an example on how it could be done combining regex and and list of strings

https://github.com/pcrespov/sandbox-python/blob/a65378079615d259832fdfec436d8a8f7ed08460/pydantic-lib/test_settings.py

and this is the associated env-file

so something like

DIRECTOR_V2_SERVICES_CUSTOM_CONSTRAINT: list[constr(strip_whitespace=True, regex=PATTERN)] = []

[GitHK]

Thanks for the nice suggestion!

[pcrespov]

Please check the suggesion on the lists above. I would also add in that case a default_factory=list as default and remove the Optional so you always get a list

[mrnicegyu11]

thanks, looks good to me

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.5% Duplication