Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e: test sim4life-dy #3060

Merged
merged 3 commits into from
May 20, 2022
Merged

e2e: test sim4life-dy #3060

merged 3 commits into from
May 20, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented May 20, 2022 •
edited

  • test sim4life-dy

@odeimaiz odeimaiz changed the title test s4l-dy e2e: test sim4life-dy May 20, 2022
@odeimaiz odeimaiz self-assigned this May 20, 2022
@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label May 20, 2022
@odeimaiz odeimaiz added this to the Croissant milestone May 20, 2022
@codecov
Copy link

codecov bot commented May 20, 2022 •
edited

Codecov Report

Merging #3060 (1afc9f3) into master (a501cc6) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3060     +/-   ##
========================================
- Coverage    80.7%   80.7%   -0.1%     
========================================
  Files         714     714             
  Lines       30782   30782             
  Branches     4019    4019             
========================================
- Hits        24867   24864      -3     
- Misses       5055    5056      +1     
- Partials      860     862      +2
Flag Coverage Δ
integrationtests 66.2% <ø> (ø)
unittests 76.7% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../director/src/simcore_service_director/producer.py 62.3% <0.0%> (-0.7%) ⬇️
...imcore_service_webserver/garbage_collector_core.py 68.2% <0.0%> (-0.7%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 81.9% <0.0%> (+0.4%) ⬆️

KZzizzle
KZzizzle approved these changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this. is. amazeballs.

elisabettai
elisabettai reviewed May 20, 2022
View reviewed changes
Copy link
Contributor

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sonarcloud
Copy link

sonarcloud bot commented May 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz merged commit 3a7ddee into ITISFoundation:master May 20, 2022
@sanderegg sanderegg mentioned this pull request Jun 2, 2022
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elisabettai elisabettai elisabettai left review comments

@GitHK GitHK GitHK approved these changes

@KZzizzle KZzizzle KZzizzle approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@colinRawlings colinRawlings Awaiting requested review from colinRawlings

@mrnicegyu11 mrnicegyu11 Awaiting requested review from mrnicegyu11

@Surfict Surfict Awaiting requested review from Surfict

Assignees

@odeimaiz odeimaiz

Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Milestone
Croissant
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@odeimaiz @GitHK @elisabettai @KZzizzle @pcrespov @sanderegg