Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jupyterlabs sim4life in the e2e #3068

Merged

Conversation

colinRawlings
Copy link
Contributor

@colinRawlings colinRawlings commented May 23, 2022

🐛 Switch e2e to jupyterlab sim4life

What do these changes do?

Improve the focus of the jupyters e2e test by:

  • using the sim4life jupyter which uses the dynamic sidecar, jupyterlab3 and sim4life
  • check that running basic sim4life functionality succeeds (parallel plates tutorial including solve and postpro)

Also:

  • Increase the time for shutdown to avoid failures with services that use the dynamic sidecar (e.g. Sim4Life)

Related issue/s

How to test

Run the e2e test following Odei's instructions at the top of: osparc-simcore/tests/e2e/tutorials/jupyterlabs.js

Checklist

@colinRawlings colinRawlings changed the title Switch to the jupyterlab test Use jupyterlabs sim4life in the e2e May 23, 2022


// Run the jlab nbook
let iframeHandles2 = await tutorial.getIframe();
Copy link
Member

@odeimaiz odeimaiz May 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all lets can now be consts

colinRawlings and others added 3 commits May 23, 2022 17:58
Co-authored-by: Odei Maiz <33152403+odeimaiz@users.noreply.github.com>
Co-authored-by: Odei Maiz <33152403+odeimaiz@users.noreply.github.com>
Co-authored-by: Odei Maiz <33152403+odeimaiz@users.noreply.github.com>
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #3068 (8dc61e6) into master (1fd02f3) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3068     +/-   ##
========================================
- Coverage    80.8%   80.7%   -0.1%     
========================================
  Files         714     714             
  Lines       30782   30782             
  Branches     4019    4019             
========================================
- Hits        24878   24866     -12     
- Misses       5042    5050      +8     
- Partials      862     866      +4     
Flag Coverage Δ
integrationtests 66.2% <ø> (-0.1%) ⬇️
unittests 76.7% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ector_v2/modules/comp_scheduler/background_task.py 83.3% <0.0%> (-8.4%) ⬇️
...ore_service_director_v2/utils/client_decorators.py 73.3% <0.0%> (-3.4%) ⬇️
...c/simcore_service_catalog/core/background_tasks.py 66.3% <0.0%> (-3.2%) ⬇️
...mcore_service_webserver/garbage_collector_utils.py 79.4% <0.0%> (-3.0%) ⬇️
...rector_v2/modules/comp_scheduler/base_scheduler.py 86.7% <0.0%> (-1.9%) ⬇️
...e_service_director_v2/modules/dask_clients_pool.py 92.7% <0.0%> (-1.5%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 90.6% <0.0%> (-1.1%) ⬇️
..._director_v2/modules/dynamic_sidecar/docker_api.py 87.2% <0.0%> (-0.9%) ⬇️
...simcore_service_director_v2/modules/dask_client.py 91.9% <0.0%> (-0.7%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 81.4% <0.0%> (-0.5%) ⬇️
... and 5 more

@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@odeimaiz odeimaiz requested a review from KZzizzle May 23, 2022 16:15
Copy link
Collaborator

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Copy link
Collaborator

@KZzizzle KZzizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

second time's the charm

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice! thanks!

@colinRawlings colinRawlings merged commit d38fe91 into ITISFoundation:master May 24, 2022
@odeimaiz odeimaiz added this to the Croissant milestone May 25, 2022
@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants