-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jupyterlabs sim4life in the e2e #3068
Use jupyterlabs sim4life in the e2e #3068
Conversation
tests/e2e/tutorials/jupyterlabs.js
Outdated
|
||
|
||
// Run the jlab nbook | ||
let iframeHandles2 = await tutorial.getIframe(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all let
s can now be const
s
Co-authored-by: Odei Maiz <33152403+odeimaiz@users.noreply.github.com>
Co-authored-by: Odei Maiz <33152403+odeimaiz@users.noreply.github.com>
Co-authored-by: Odei Maiz <33152403+odeimaiz@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #3068 +/- ##
========================================
- Coverage 80.8% 80.7% -0.1%
========================================
Files 714 714
Lines 30782 30782
Branches 4019 4019
========================================
- Hits 24878 24866 -12
- Misses 5042 5050 +8
- Partials 862 866 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
second time's the charm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice! thanks!
🐛 Switch e2e to jupyterlab sim4life
What do these changes do?
Improve the focus of the
jupyters
e2e test by:sim4life jupyter
which uses the dynamic sidecar, jupyterlab3 and sim4lifeAlso:
Sim4Life
)Related issue/s
How to test
Run the e2e test following Odei's instructions at the top of:
osparc-simcore/tests/e2e/tutorials/jupyterlabs.js
Checklist