-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⬆️ Maintenance: fixes downstream upgrades and reduces version dispersion #3092
⬆️ Maintenance: fixes downstream upgrades and reduces version dispersion #3092
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3092 +/- ##
======================================
Coverage 80.9% 81.0%
======================================
Files 716 716
Lines 30924 30924
Branches 4035 4035
======================================
+ Hits 25042 25052 +10
+ Misses 5006 4998 -8
+ Partials 876 874 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
7ec3c75
to
97d6e94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice additions!
Please see my comments below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we have 2 different versions of dask/distributed. I think that is not good as they usually do not like having different versions, do we know why?
also, how do you define what is a critical library (you wrote that in the PR description)? Why aioboto3? or fastapi?
Kudos, SonarCloud Quality Gate passed!
|
@sanderegg this is a bulk upgrade where I try to minimize the risk of incompatibility. I call critical libraries those that we mainly use directly in the development of some of the services/libraries in osparc-simcore. E.g. we use a lot of the functions in fastapi, aiohttp etc directly in our code. For those I prefer to have separate PRs since experience show that upgrades of those have a higher risk of breaking our code. In the case of aioboto3 I did not want to upgrade until you merge your changes in storage For dask/distributed we will do a separate upgrade (notice that the difference is in the package not in the service requirements). Moreover, we can enforce that those always have the same version |
What do these changes do?
This PR address requirement updates across the entire repository.
Sometimes, after changing requirements in
packages
we forget to update downstream. This creates inconsistencies when installing services between the frozen lists (_base.txt
) and the installed libraries (seemake install-ci pip-freeze
).Another issue is the different versions of any given library listed in different requirements across the repository. We denote this as "version dispersion" and aim to reduce it as much as the constraints set allow. For that we use selective updates of libraries based on the second table overview below.
Specifics:
servicelib
reqs were updated forgot to update downstream)fastapi
,boto3
...) were not included in this updateHighlights on updated libraries (only updated libraries are included)
catalog⬆️🧪
director-v2⬆️🧪
dynamic-sidecar⬆️
models-library🧪
postgres-database🧪🧪
simcore-sdk🧪🧪
storage⬆️
swarm-deploy🧪
web⬆️🧪
catalog⬆️🧪
dask-sidecar⬆️
director-v2⬆️🧪
dynamic-sidecar⬆️
public-api🧪
service-library🧪
catalog⬆️
director-v2⬆️
dynamic-sidecar⬆️
dask-sidecar⬆️🧪
datcore-adapter🧪
catalog⬆️🧪
dask-sidecar⬆️🧪
dask-task-models-library🧪
director-v2⬆️🧪
dynamic-sidecar⬆️🧪
e2e🧪
models-library🧪
postgres-database🧪🧪
public-api🧪
service-integration🧪🧪
service-library🧪
settings-library🧪
simcore-sdk🧪
storage⬆️🧪
swarm-deploy🧪
web🧪
dynamic-sidecar⬆️
director-v2⬆️🧪
dynamic-sidecar⬆️🧪
dask-sidecar⬆️🧪
director-v2⬆️🧪
dynamic-sidecar⬆️
dask-sidecar⬆️⬆️⬆️⬆️🔧
director-v2⬆️🔧
dynamic-sidecar⬆️🔧
storage⬆️🔧
catalog⬆️
dask-sidecar⬆️⬆️
datcore-adapter⬆️
director-v2⬆️
dynamic-sidecar⬆️
storage⬆️
catalog⬆️
storage⬆️
models-library🧪
public-api🧪
service-integration🧪
tests🧪
dask-sidecar⬆️⬆️⬆️⬆️
director-v2⬆️🧪
dynamic-sidecar⬆️
dask-sidecar⬆️🧪
director-v2⬆️🧪
dynamic-sidecar⬆️🧪
catalog⬆️
director-v2⬆️
web⬆️
dask-sidecar⬆️⬆️⬆️⬆️🧪
director-v2⬆️🧪
dynamic-sidecar⬆️🧪
dynamic-sidecar⬆️
director-v2⬆️
dynamic-sidecar⬆️
service-library🧪
storage⬆️
dask-task-models-library🧪
director-v2⬆️
director-v2⬆️🧪
dynamic-sidecar⬆️
dask-sidecar⬆️
director-v2⬆️
dynamic-sidecar⬆️
catalog⬆️🧪
dask-sidecar⬆️⬆️⬆️⬆️🧪
dask-task-models-library🧪🧪
datcore-adapter🧪
director-v2⬆️🧪
dynamic-sidecar⬆️🧪
environment-setup🧪
models-library🧪
postgres-database🧪
public-api🧪
service-integration🧪🧪
service-library🧪
settings-library🧪
simcore-sdk🧪🧪
storage🧪
swarm-deploy🧪
tests🧪
dynamic-sidecar⬆️
dask-sidecar⬆️🧪
director-v2⬆️🧪
dynamic-sidecar⬆️
dask-sidecar⬆️🧪
director-v2⬆️🧪
dynamic-sidecar⬆️🧪
catalog⬆️🧪
director-v2⬆️🧪
dynamic-sidecar⬆️
models-library🧪
postgres-database🧪🧪🧪
service-library🧪
simcore-sdk🧪🧪
storage⬆️
swarm-deploy🧪
web⬆️🧪
dask-sidecar⬆️
director-v2⬆️
catalog⬆️
director-v2⬆️
dynamic-sidecar⬆️
catalog⬆️🧪🔧
director-v2⬆️🧪🔧
dynamic-sidecar⬆️🔧
storage⬆️🧪🔧
director-v2⬆️
storage⬆️
web⬆️
dask-sidecar⬆️⬆️⬆️⬆️🧪
director-v2⬆️🧪
dynamic-sidecar⬆️🧪
director-v2⬆️
catalog⬆️
director-v2⬆️
storage⬆️🧪
dask-sidecar⬆️🧪
dynamic-sidecar⬆️
director-v2⬆️
Legend:
Repo-wide overview of libraries
This table shows the version dispersion across the repository after this PR