-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃敤 Maintenance/pyupgrade code base targeting py3.9 #3122
馃敤 Maintenance/pyupgrade code base targeting py3.9 #3122
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3122 +/- ##
========================================
- Coverage 81.0% 80.9% -0.1%
========================================
Files 706 706
Lines 30458 30457 -1
Branches 3945 3945
========================================
- Hits 24673 24657 -16
- Misses 4938 4951 +13
- Partials 847 849 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Glad this will go out of the way.
Please see below some minor stuff and questions.
packages/pytest-simcore/src/pytest_simcore/helpers/utils_tokens.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty nice tool!
so the idea is to use it later on right? cause I can imagine some PR will be not so nice to merge afterwards...
Yes. Easy. That is why this PR only upgrades non-critical packages |
Kudos, SonarCloud Quality Gate passed!聽 聽
|
Nice! |
What do these changes do?
The entire repo (*) use python 3.9.
Upgrading to the new syntax (e.g.
List
->list
-like ) is very time consuming, noisy and error-prone.This PR uses pyupgrade to automatically upgrade targeted code syntax to py3.9
tests
,api
andpackages/settings-library
). Subsequent PRs will address packages and then one service at a time.scripts/pyupgrade.bash
(*) Except for
services/director
and some files inpackages/pytest-simcore
used as well thereHow to test
TODO
scripts/
with containarized tool