Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make login form password save friendly #315

Merged
merged 2 commits into from Nov 7, 2018
Merged

Make login form password save friendly #315

merged 2 commits into from Nov 7, 2018

Conversation

oetiker
Copy link
Member

@oetiker oetiker commented Nov 7, 2018 •
edited

What do these changes do?

If we want to have the browser save the content of a form (like the login form) we must provide some annotations as explained in in: https://www.chromium.org/developers/design-documents/create-amazing-password-forms

Related issue number

connected to #19

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • Runs in the swarm
  • If you design a new module, add your user to .github/CODEOWNERS

@ghost ghost assigned oetiker Nov 7, 2018
@ghost ghost added the review label Nov 7, 2018
@odeimaiz odeimaiz merged commit 049a185 into ITISFoundation:master Nov 7, 2018
@ghost ghost removed the review label Nov 7, 2018
@oetiker oetiker mentioned this pull request Nov 13, 2018
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcrespov pcrespov pcrespov approved these changes

@odeimaiz odeimaiz odeimaiz approved these changes

Assignees

@oetiker oetiker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oetiker @pcrespov @odeimaiz