🐛 (⚠️ devops) Fix validation of DIRECTOR_V2_SERVICES_CUSTOM_CONSTRAINTS: Make it conform to docker specs

[mrnicegyu11]

What do these changes do?

Allow underscore in DIRECTOR_V2_SERVICES_CUSTOM_CONSTRAINTS in regex validation during container start

Before:
node.labels.standard_worker==true --> invalid
node.labels.standardworker==true --> valid

Now:
node.labels.standard_worker==true --> valid
node.labels.standardworker==true --> valid

(⚠️ devops)

• make sure the variable DIRECTOR_V2_SERVICES_CUSTOM_CONSTRAINTS on all deployments adheres to the new tighter constraints, which is identical to the docker spec https://docs.docker.com/config/labels-custom-metadata/#label-keys-and-values

[codecov]

Codecov Report

Merging #3190 (f15c49e) into master (06ed666) will increase coverage by 0.9%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #3190     +/-   ##
========================================
+ Coverage    81.0%   82.0%   +0.9%     
========================================
  Files         740     740             
  Lines       31572   31572             
  Branches     4081    4081             
========================================
+ Hits        25602   25892    +290     
+ Misses       5147    4846    -301     
- Partials      823     834     +11     

Flag	Coverage Δ
integrationtests	66.5% <ø> (+4.7%)	⬆️
unittests	78.5% <ø> (-0.1%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...2/src/simcore_service_director_v2/core/settings.py	96.5% <ø> (ø)
...rvice_datcore_adapter/utils/requests_decorators.py	68.4% <0.0%> (-10.6%)	⬇️
...ector_v2/modules/comp_scheduler/background_task.py	83.3% <0.0%> (-8.4%)	⬇️
...mcore_service_webserver/garbage_collector_utils.py	82.0% <0.0%> (-2.6%)	⬇️
...service_director_v2/api/routes/dynamic_services.py	87.2% <0.0%> (+0.9%)	⬆️
...c/simcore_service_catalog/core/background_tasks.py	68.4% <0.0%> (+2.1%)	⬆️
.../simcore_service_catalog/db/repositories/groups.py	75.6% <0.0%> (+2.7%)	⬆️
...or_v2/models/schemas/dynamic_services/scheduler.py	98.4% <0.0%> (+3.0%)	⬆️
...rc/simcore_service_director_v2/core/application.py	90.4% <0.0%> (+3.1%)	⬆️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py	80.4% <0.0%> (+3.9%)	⬆️
... and 10 more

[pcrespov]

pair reviewed. Expected test as agreed. thx

[GitHK]

you can remove this comment, it's fine like this

[GitHK]

just make sure to remove this comment

[GitHK]

Also add the following test case

('["underscore_label==underscore_value"]', ["underscore_label==underscore_value"]),

[GitHK]

Since you are changing these, please also add the above suggestions. Thanks!

[mrnicegyu11]

Since you are changing these, please also add the above suggestions. Thanks!

I intentionally did not, it is unclear and untested if this is even permitted from docker.
Let's keep the changes small and atomic and not overdo it.
This change currently prevents master from booting, so I would be happy if it gets in @GitHK

[GitHK]

Since you are changing these, please also add the above suggestions. Thanks!

I intentionally did not, it is unclear and untested if this is even permitted from docker. Let's keep the changes small and atomic and not overdo it. This change currently prevents master from booting, so I would be happy if it gets in @GitHK

Let's have a look at the docs.

Apparently the key part of the label cannot contain underscores but only alphanumerical character and . and -. Please replace the _ with - in the tests and in the regex.

Regarding the value part of the label, all valid json encodable characters are ok. So _ is ok as well.

[GitHK]

👍 Thanks for taking care of this

[GitHK]

just make sure to remove this comment

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication