Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 fix typos in release instruction for hotfix staging #3358

Conversation

mrnicegyu11
Copy link
Member

@mrnicegyu11 mrnicegyu11 commented Sep 15, 2022

There are typos in the release instructions doc that prevented the hotfix-staging-release github action from running through. An underscore is missing.

Compare with osparc-simcore/.github/workflows/ci-staging.yml:58ff:

- if: contains(env.BRANCH_NAME, 'remotes/origin/hotfix_staging_')
        env:
          FROM_TAG_PREFIX: hotfix-staging-github
        name: deploy from hotfix staging to staging
        run: ./ci/deploy/dockerhub-tag-version.bash

@mrnicegyu11 mrnicegyu11 added bug buggy, it does not work as expected a:doc documentation, reporting, admin tasks labels Sep 15, 2022
@mrnicegyu11 mrnicegyu11 self-assigned this Sep 15, 2022
@mrnicegyu11 mrnicegyu11 added this to the vaporwave milestone Sep 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mrnicegyu11 mrnicegyu11 changed the title fix typos in release instruction for hotfix staging 馃悰 fix typos in release instruction for hotfix staging Sep 15, 2022
@sanderegg
Copy link
Member

@mrnicegyu11 : I guess you do not have zenhub installed. I can show you how that works since this allows to link the issues to the maintenance case epic, which simplifies a lot managing all these issues as well as reporting.

@mrnicegyu11
Copy link
Member Author

@sanderegg yep don't have it yet, let's do it :)

Copy link
Member

@odeimaiz odeimaiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@mrnicegyu11 mrnicegyu11 merged commit 181170b into ITISFoundation:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:doc documentation, reporting, admin tasks bug buggy, it does not work as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants