-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance/ lgtm+CodeQL fixes #3363
Maintenance/ lgtm+CodeQL fixes #3363
Conversation
…-commit tools on all migration
Codecov Report
@@ Coverage Diff @@
## master #3363 +/- ##
======================================
Coverage 82.9% 82.9%
======================================
Files 807 807
Lines 34197 34187 -10
Branches 1358 1358
======================================
- Hits 28376 28369 -7
+ Misses 5639 5636 -3
Partials 182 182
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what lgtm does.. removes the from asyncio import...
when there is already a import asyncio
is that so?
@sanderegg it is a style rule that I think it's reasonable: https://lgtm.com/rules/1818040193/ |
What do these changes do?
Does some fixes to keep up with issues found by LGTM which is now integrated in github's CodeQL and runs on our repo every Monday morning
packages/postgres-database
packages/service-library
services/catalog
services/dask-sidecar
services/datcore-adapter
storage
Related issue/s
How to test
Checklist