Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance/ lgtm+CodeQL fixes #3363

Merged
merged 10 commits into from
Sep 19, 2022

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Sep 18, 2022

What do these changes do?

Does some fixes to keep up with issues found by LGTM which is now integrated in github's CodeQL and runs on our repo every Monday morning

  • In order to keep the PR reasonably short and contained, we have done some fixes in the following:
    • packages/postgres-database
    • packages/service-library
    • services/catalog
    • services/dask-sidecar
    • services/datcore-adapter
    • storage
  • See commits for description of changes.

Related issue/s

  • Part of osparc-issues/issues/675

How to test

Checklist

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #3363 (dc702f2) into master (ddecdef) will increase coverage by 0.0%.
The diff coverage is 93.7%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3363   +/-   ##
======================================
  Coverage    82.9%   82.9%           
======================================
  Files         807     807           
  Lines       34197   34187   -10     
  Branches     1358    1358           
======================================
- Hits        28376   28369    -7     
+ Misses       5639    5636    -3     
  Partials      182     182           
Flag Coverage Δ
integrationtests 68.3% <100.0%> (+<0.1%) ⬆️
unittests 79.5% <93.7%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...se/src/simcore_postgres_database/sidecar_models.py 0.0% <0.0%> (ø)
...se/src/simcore_postgres_database/storage_models.py 100.0% <ø> (ø)
...tion/src/service_integration/compose_spec_model.py 100.0% <ø> (ø)
...rc/servicelib/fastapi/long_running_tasks/client.py 100.0% <ø> (ø)
...e/src/simcore_service_storage/db_file_meta_data.py 98.1% <ø> (ø)
...rvice_datcore_adapter/utils/requests_decorators.py 83.7% <66.6%> (-0.5%) ⬇️
...database/src/simcore_postgres_database/__init__.py 100.0% <100.0%> (ø)
...s-database/src/simcore_postgres_database/errors.py 100.0% <100.0%> (ø)
...e/src/simcore_postgres_database/models/__init__.py 100.0% <100.0%> (ø)
...e/src/simcore_postgres_database/utils_aiopg_orm.py 84.4% <100.0%> (ø)
... and 23 more

@pcrespov pcrespov changed the title Maintenance/lgtm fixes Maintenance/ lgtm+CodeQL fixes Sep 18, 2022
@pcrespov pcrespov self-assigned this Sep 18, 2022
@pcrespov pcrespov added a:storage issue related to storage service a:services-library issues on packages/service-libs a:database associated to postgres service and postgres-database package t:maintenance Some planned maintenance work a:catalog catalog service a:dask-service Any of the dask services: dask-scheduler/sidecar or worker labels Sep 18, 2022
@pcrespov pcrespov added this to the vaporwave milestone Sep 18, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov marked this pull request as ready for review September 18, 2022 22:51
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what lgtm does.. removes the from asyncio import... when there is already a import asyncio is that so?

@pcrespov
Copy link
Member Author

not sure what lgtm does.. removes the from asyncio import... when there is already a import asyncio is that so?

@sanderegg it is a style rule that I think it's reasonable: https://lgtm.com/rules/1818040193/

@pcrespov pcrespov merged commit 59c34d8 into ITISFoundation:master Sep 19, 2022
@pcrespov pcrespov deleted the maintenance/lgtm-fixes branch September 19, 2022 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:catalog catalog service a:dask-service Any of the dask services: dask-scheduler/sidecar or worker a:database associated to postgres service and postgres-database package a:services-library issues on packages/service-libs a:storage issue related to storage service t:maintenance Some planned maintenance work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants