Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Bug?fix: template permissions #3398

Merged
merged 8 commits into from
Sep 29, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Sep 28, 2022

What do these changes do?

Study and Template Collaborators have permission for editing the metadata: title, description, TSR, accessRights...

When sharing a Study or Template using the frontend, by default, they get Collaborator role. This might be convenient for Studies, but not for Templates. This PR makes the default role to be Viewer for Templates.

Before:
Share

After:
Share2

Bonus:

  • Word wrap in study card title

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz added this to the vaporwave milestone Sep 28, 2022
@odeimaiz odeimaiz self-assigned this Sep 28, 2022
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #3398 (892e3e5) into master (0c2b45f) will increase coverage by 3.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3398     +/-   ##
========================================
+ Coverage    79.9%   83.0%   +3.1%     
========================================
  Files         816     816             
  Lines       34583   34583             
  Branches     1362    1362             
========================================
+ Hits        27663   28737   +1074     
+ Misses       6752    5665   -1087     
- Partials      168     181     +13     
Flag Coverage 螖
integrationtests 68.5% <酶> (?)
unittests 79.9% <酶> (-0.1%) 猬囷笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
...log/src/simcore_service_catalog/api/routes/dags.py 62.7% <0.0%> (-11.7%) 猬囷笍
.../simcore_service_catalog/db/repositories/groups.py 67.5% <0.0%> (-5.5%) 猬囷笍
...rc/simcore_service_catalog/db/repositories/dags.py 44.4% <0.0%> (-2.8%) 猬囷笍
.../director/src/simcore_service_director/producer.py 67.3% <0.0%> (-0.3%) 猬囷笍
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 83.4% <0.0%> (酶)
...rvice_webserver/projects/projects_handlers_crud.py 93.0% <0.0%> (+0.4%) 猬嗭笍
.../simcore_service_webserver/projects/projects_db.py 95.6% <0.0%> (+0.5%) 猬嗭笍
...or_v2/models/schemas/dynamic_services/scheduler.py 99.2% <0.0%> (+0.7%) 猬嗭笍
...simcore_service_director_v2/modules/node_rights.py 99.0% <0.0%> (+0.9%) 猬嗭笍
...r-v2/src/simcore_service_director_v2/utils/dask.py 89.5% <0.0%> (+1.1%) 猬嗭笍
... and 59 more

@odeimaiz odeimaiz changed the title WIP: Bugfix: template permissions WIP: Minor: template and service permissions Sep 28, 2022
@odeimaiz odeimaiz changed the title WIP: Minor: template and service permissions WIP: Bug?fix: template and service permissions Sep 28, 2022
@odeimaiz odeimaiz marked this pull request as ready for review September 28, 2022 11:42
@odeimaiz odeimaiz changed the title WIP: Bug?fix: template and service permissions 馃悰 Bug?fix: template and service permissions Sep 28, 2022
@odeimaiz odeimaiz changed the title 馃悰 Bug?fix: template and service permissions 馃悰 Bug?fix: template permissions Sep 28, 2022
@odeimaiz odeimaiz added a:frontend issue affecting the front-end (area group) changelog:馃帹enhancement labels Sep 28, 2022
Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃帀

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

Copy link
Contributor

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Luckily you've fixed before someone complained. (:

@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2022

Kudos, SonarCloud Quality Gate passed!聽 聽 Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odeimaiz odeimaiz merged commit 65a95cd into ITISFoundation:master Sep 29, 2022
@odeimaiz odeimaiz deleted the fix/template-access-rights branch September 29, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:frontend issue affecting the front-end (area group)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants