Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Correctly retry AWS 500 Internal error when uploading file #3403

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

GitHK
Copy link
Contributor

@GitHK GitHK commented Oct 3, 2022

What do these changes do?

Apparently the 500 errors were not handled causing failures from S3TransferErrors on AWS prod.

web.HTTPServerError has an internal status of -1 the correct exception would be web.HTTPInternalServerError which is a 500.

Related issue/s

How to test

Checklist

@GitHK GitHK marked this pull request as ready for review October 3, 2022 09:34
@GitHK GitHK added this to the vaporwave milestone Oct 3, 2022
@GitHK GitHK self-assigned this Oct 3, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.2% 0.2% Duplication

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #3403 (6eeb68d) into master (e584132) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3403   +/-   ##
======================================
  Coverage    83.0%   83.1%           
======================================
  Files         818     818           
  Lines       34680   34680           
  Branches     1363    1363           
======================================
+ Hits        28813   28821    +8     
+ Misses       5686    5678    -8     
  Partials      181     181           
Flag Coverage Δ
integrationtests 68.2% <ø> (+<0.1%) ⬆️
unittests 80.0% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/simcore_sdk/node_ports_common/file_io_utils.py 85.5% <ø> (ø)
...ector_v2/modules/comp_scheduler/background_task.py 87.5% <0.0%> (-8.4%) ⬇️
...ore_service_director_v2/utils/client_decorators.py 80.0% <0.0%> (-3.4%) ⬇️
...e_service_director_v2/modules/dask_clients_pool.py 94.2% <0.0%> (-1.5%) ⬇️
...rector_v2/modules/comp_scheduler/base_scheduler.py 91.1% <0.0%> (-1.3%) ⬇️
...tor_v2/modules/dynamic_sidecar/docker_api/_core.py 95.5% <0.0%> (-1.0%) ⬇️
...simcore_service_director_v2/modules/dask_client.py 92.8% <0.0%> (-0.6%) ⬇️
...imcore_service_webserver/garbage_collector_core.py 70.4% <0.0%> (+0.6%) ⬆️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 84.2% <0.0%> (+0.7%) ⬆️
...simcore_service_director_v2/modules/node_rights.py 99.0% <0.0%> (+0.9%) ⬆️
... and 5 more

Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this fix. Maybe consider changing the title to something like:
Correctly retry AWS 500 Internal error when uploading file

@GitHK GitHK changed the title 🐛 typos causing lots of failures on AWS prod 🐛 Correctly retry AWS 500 Internal error when uploading file Oct 3, 2022
Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@GitHK GitHK merged commit 085e0bd into ITISFoundation:master Oct 3, 2022
@GitHK GitHK deleted the pr-osparc-fix-wrong-status-code branch October 3, 2022 10:11
pcrespov pushed a commit that referenced this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants