-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Correctly retry AWS 500 Internal error when uploading file #3403
🐛 Correctly retry AWS 500 Internal error when uploading file #3403
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov Report
@@ Coverage Diff @@
## master #3403 +/- ##
======================================
Coverage 83.0% 83.1%
======================================
Files 818 818
Lines 34680 34680
Branches 1363 1363
======================================
+ Hits 28813 28821 +8
+ Misses 5686 5678 -8
Partials 181 181
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for this fix. Maybe consider changing the title to something like:
Correctly retry AWS 500 Internal error when uploading file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
…) [cherry picked from master]
What do these changes do?
Apparently the 500 errors were not handled causing failures from
S3TransferErrors
on AWS prod.web.HTTPServerError
has an internal status of-1
the correct exception would beweb.HTTPInternalServerError
which is a500
.Related issue/s
How to test
Checklist