-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: More reliable output files check #3432
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
requested review from
sanderegg,
colinRawlings,
elisabettai,
GitHK,
mguidon,
mrnicegyu11 and
pcrespov
October 11, 2022 14:44
Codecov Report
@@ Coverage Diff @@
## master #3432 +/- ##
======================================
Coverage 83.3% 83.3%
======================================
Files 824 824
Lines 34918 34918
Branches 1254 1254
======================================
Hits 29090 29090
Misses 5640 5640
Partials 188 188
Flags with carried forward coverage won't be shown. Click here to find out more.
|
sanderegg
approved these changes
Oct 11, 2022
pcrespov
approved these changes
Oct 11, 2022
GitHK
approved these changes
Oct 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
There are some e2e and p2e tests that fail checking output files and the tests still pass. This PR tries to fix those false positives.
Funny enough, I don't see why these error show up in the first place. Therefore, I also print the expected vs received.
Related issue/s
How to test
Checklist