Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e: More reliable output files check #3432

Merged
merged 6 commits into from
Oct 12, 2022

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Oct 11, 2022

What do these changes do?

There are some e2e and p2e tests that fail checking output files and the tests still pass. This PR tries to fix those false positives.
Funny enough, I don't see why these error show up in the first place. Therefore, I also print the expected vs received.

Related issue/s

How to test

Checklist

@odeimaiz odeimaiz self-assigned this Oct 11, 2022
@odeimaiz odeimaiz changed the title E2e/check files e2e: More reliable output files check Oct 11, 2022
@odeimaiz odeimaiz added this to the Untitled Sprint milestone Oct 11, 2022
@odeimaiz odeimaiz marked this pull request as ready for review October 11, 2022 14:39
@odeimaiz odeimaiz added the e2e Bugs found by or related to the end-2-end testing label Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #3432 (794b59a) into master (566446d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3432   +/-   ##
======================================
  Coverage    83.3%   83.3%           
======================================
  Files         824     824           
  Lines       34918   34918           
  Branches     1254    1254           
======================================
  Hits        29090   29090           
  Misses       5640    5640           
  Partials      188     188           
Flag Coverage Δ
integrationtests 68.2% <ø> (-0.1%) ⬇️
unittests 80.1% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../simcore_service_catalog/db/repositories/groups.py 67.5% <0.0%> (-5.5%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/_utils.py 90.8% <0.0%> (-1.2%) ⬇️
...simcore_service_director_v2/modules/node_rights.py 98.1% <0.0%> (-1.0%) ⬇️
...imcore_service_webserver/garbage_collector_core.py 69.8% <0.0%> (-0.7%) ⬇️
.../director/src/simcore_service_director/producer.py 67.3% <0.0%> (-0.3%) ⬇️
...tor_v2/modules/dynamic_sidecar/docker_api/_core.py 96.5% <0.0%> (+1.0%) ⬆️
.../simcore_service_catalog/services/access_rights.py 87.5% <0.0%> (+1.2%) ⬆️
...mcore_service_webserver/garbage_collector_utils.py 87.1% <0.0%> (+1.2%) ⬆️
...r_v2/modules/dynamic_sidecar/docker_api/_volume.py 100.0% <0.0%> (+1.6%) ⬆️
...rc/simcore_service_catalog/db/repositories/dags.py 47.2% <0.0%> (+2.7%) ⬆️

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odeimaiz odeimaiz merged commit de6da4c into ITISFoundation:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Bugs found by or related to the end-2-end testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants