Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 is3372/fixes warning of alias in BaseSettings #3454

Merged

Conversation

pcrespov
Copy link
Member

@pcrespov pcrespov commented Oct 17, 2022

What do these changes do?

Cannot use alias with BaseSettings. Created instead a helper in webserver's ApplicationSettings just for the special export functions.

EXTRA: improved a bit speed of web-server's CLI simcore-service-webserver --help by reducing explicit imports

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv --pdb  tests/**/test_application*.py

@pcrespov pcrespov self-assigned this Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #3454 (1ffe810) into master (5ac6e4e) will increase coverage by 0.0%.
The diff coverage is 62.5%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #3454   +/-   ##
======================================
  Coverage    83.3%   83.3%           
======================================
  Files         825     825           
  Lines       34946   34953    +7     
  Branches      739     739           
======================================
+ Hits        29119   29135   +16     
+ Misses       5640    5631    -9     
  Partials      187     187           
Flag Coverage Δ
integrationtests 68.2% <6.2%> (+<0.1%) ⬆️
unittests 80.2% <62.5%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/web/server/src/simcore_service_webserver/cli.py 47.0% <0.0%> (-10.6%) ⬇️
.../simcore_service_webserver/application_settings.py 98.6% <100.0%> (+<0.1%) ⬆️
.../src/simcore_service_webserver/projects/_delete.py 85.4% <0.0%> (-5.5%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/_utils.py 93.1% <0.0%> (-3.5%) ⬇️
...rc/simcore_service_catalog/db/repositories/dags.py 44.4% <0.0%> (-2.8%) ⬇️
...imcore_service_webserver/garbage_collector_core.py 69.2% <0.0%> (-0.7%) ⬇️
...ector_v2/modules/dynamic_sidecar/scheduler/task.py 84.2% <0.0%> (+0.7%) ⬆️
.../simcore_service_catalog/services/access_rights.py 87.5% <0.0%> (+1.2%) ⬆️
...mcore_service_webserver/garbage_collector_utils.py 87.1% <0.0%> (+1.2%) ⬆️
...rary/src/servicelib/fastapi/requests_decorators.py 84.3% <0.0%> (+3.9%) ⬆️
... and 3 more

@pcrespov pcrespov force-pushed the is3372/fixes-base-settings-alias branch from c4bc82e to b49a188 Compare October 17, 2022 17:00
@pcrespov pcrespov marked this pull request as ready for review October 17, 2022 17:01
@pcrespov pcrespov added the a:webserver issue related to the webserver service label Oct 17, 2022
@pcrespov pcrespov added this to the Katherine Switzer milestone Oct 17, 2022
Copy link
Member

@sanderegg sanderegg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@pcrespov pcrespov requested a review from GitHK October 18, 2022 07:19
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pcrespov pcrespov merged commit 8b8621d into ITISFoundation:master Oct 18, 2022
@pcrespov pcrespov deleted the is3372/fixes-base-settings-alias branch October 18, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a:webserver issue related to the webserver service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix BaseSettings aliases
3 participants