-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 is3372/fixes warning of alias in BaseSettings #3454
🐛 is3372/fixes warning of alias in BaseSettings #3454
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3454 +/- ##
======================================
Coverage 83.3% 83.3%
======================================
Files 825 825
Lines 34946 34953 +7
Branches 739 739
======================================
+ Hits 29119 29135 +16
+ Misses 5640 5631 -9
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c4bc82e
to
b49a188
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
…v/osparc-simcore into is3372/fixes-base-settings-alias
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
Cannot use
alias
withBaseSettings
. Created instead a helper inwebserver
'sApplicationSettings
just for the special export functions.EXTRA: improved a bit speed of web-server's CLI
simcore-service-webserver --help
by reducing explicit importsRelated issue/s
How to test
cd services/web/server make install-dev pytest -vv --pdb tests/**/test_application*.py