-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Bugfix#2: datcore-adapter stops calling into pennsieve after too many requests are done? #3473
🐛 Bugfix#2: datcore-adapter stops calling into pennsieve after too many requests are done? #3473
Conversation
a1975f1
to
89fc00a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3473 +/- ##
========================================
- Coverage 83.4% 82.3% -1.2%
========================================
Files 828 828
Lines 35183 35191 +8
Branches 740 741 +1
========================================
- Hits 29363 28979 -384
- Misses 5632 6035 +403
+ Partials 188 177 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
services/datcore-adapter/src/simcore_service_datcore_adapter/utils/client_base.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for tracing and fixing this one :--)
2e89423
to
49d86a4
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
…ny requests are done? (#3473)
What do these changes do?
This PR disable http/2 on the httpx client used in the datcore-adapter.
It seems we are impacted by this: encode/httpx#2112 in httpx
current workaround is to disable http/2 protocol. sad.
should fix #3464
Related issue/s
How to test
Checklist