Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Bugfix#2: datcore-adapter stops calling into pennsieve after too many requests are done? #3473

Merged
merged 2 commits into from
Oct 26, 2022

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 25, 2022

What do these changes do?

This PR disable http/2 on the httpx client used in the datcore-adapter.
It seems we are impacted by this: encode/httpx#2112 in httpx

current workaround is to disable http/2 protocol. sad.

should fix #3464

Related issue/s

How to test

Checklist

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #3473 (2e89423) into master (97a99c0) will decrease coverage by 1.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3473     +/-   ##
========================================
- Coverage    83.4%   82.3%   -1.2%     
========================================
  Files         828     828             
  Lines       35183   35191      +8     
  Branches      740     741      +1     
========================================
- Hits        29363   28979    -384     
- Misses       5632    6035    +403     
+ Partials      188     177     -11     
Flag Coverage Δ
integrationtests 64.2% <ø> (-3.5%) ⬇️
unittests 80.3% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mcore_service_datcore_adapter/utils/client_base.py 100.0% <ø> (ø)
...simcore_service_webserver/computation_subscribe.py 27.0% <0.0%> (-66.0%) ⬇️
...k/src/simcore_sdk/node_ports_common/filemanager.py 27.5% <0.0%> (-55.8%) ⬇️
...src/simcore_sdk/node_ports_common/file_io_utils.py 37.5% <0.0%> (-46.7%) ⬇️
.../simcore_service_webserver/computation_settings.py 55.5% <0.0%> (-44.5%) ⬇️
...sdk/src/simcore_sdk/node_ports_common/dbmanager.py 42.4% <0.0%> (-43.9%) ⬇️
...ore_service_director_v2/api/routes/computations.py 63.9% <0.0%> (-29.5%) ⬇️
...erver/src/simcore_service_webserver/computation.py 75.0% <0.0%> (-25.0%) ⬇️
...e-sdk/src/simcore_sdk/node_ports_common/r_clone.py 75.4% <0.0%> (-20.8%) ⬇️
...service_webserver/projects/projects_nodes_utils.py 80.9% <0.0%> (-14.3%) ⬇️
... and 27 more

Copy link
Contributor

@GitHK GitHK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@mrnicegyu11 mrnicegyu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tracing and fixing this one :--)

@sanderegg sanderegg merged commit c6ca857 into ITISFoundation:master Oct 26, 2022
@sanderegg sanderegg deleted the bugfix/pennsieve/2 branch October 26, 2022 08:05
@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants