🐛 fix/low-CPU-load healthcheck for migration service #3477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcrespov
changed the title
pcrespov
changed the title
pcrespov
changed the title
mrnicegyu11
approved these changes
Oct 26, 2022
pcrespov
changed the title
Surfict
approved these changes
Oct 26, 2022
sanderegg
approved these changes
Oct 26, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
|
Before - After
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
New healthcheck function for the migration service with low CPU footprint.
Why this change ?
Previous healthcheck has been producing an almost constant (~13 %) CPU usage. See @mrnicegyu11's promQL request
After a couple of days, that ended up consuming all CPU credit in AWS. See outcome from @Surfict's research:
This is probably what caused the instabilities we have been experiencing in the last days in the e2e.
🚑️ This should be hot-fixed to staging before ITISFoundation/osparc-issues#753