-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛✨ Ensure adding/deleting node is thread safe #3490
🐛✨ Ensure adding/deleting node is thread safe #3490
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3490 +/- ##
=========================================
- Coverage 83.5% 78.6% -4.9%
=========================================
Files 828 349 -479
Lines 35201 17756 -17445
Branches 744 133 -611
=========================================
- Hits 29394 13967 -15427
+ Misses 5617 3740 -1877
+ Partials 190 49 -141
Flags with carried forward coverage won't be shown. Click here to find out more.
|
67bd50e
to
ca6672c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic
Please check some minor below
services/web/server/src/simcore_service_webserver/projects/projects_api.py
Outdated
Show resolved
Hide resolved
await storage_api.delete_data_folders_of_project_node( | ||
request.app, project_uuid, node_uuid, user_id | ||
request.app, f"{project_uuid}", node_uuid, user_id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THOUGHT: I find shame that we go back and forth from UUID to string and then back to uuid ...
When converted to the str we lose the guarantee of a valid UUID downstream ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, did you see I changed the syntax of delete_node?
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
What do these changes do?
This goes along the lines needed for ITISFoundation/osparc-issues#756
Next steps will be to:
through the backend as well.
Bonus:
Related issue/s
How to test
Checklist