Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Use latest rabbit MQ service #3496

Conversation

sanderegg
Copy link
Member

@sanderegg sanderegg commented Oct 31, 2022

What do these changes do?

  • uses latest itisfoundation/rabbitmq:3.11.2-management image

⚠️ devops: In case this is set somewhere, you will need to change the version accordingly

Related issue/s

How to test

Checklist

@sanderegg sanderegg self-assigned this Oct 31, 2022
@sanderegg sanderegg added this to the Katherine Switzer milestone Oct 31, 2022
@sanderegg sanderegg marked this pull request as ready for review October 31, 2022 16:38
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #3496 (6489e9f) into master (d934fec) will decrease coverage by 1.9%.
The diff coverage is n/a.

❗ Current head 6489e9f differs from pull request most recent head 18027f2. Consider uploading reports for the commit 18027f2 to get more accurate results

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #3496     +/-   ##
========================================
- Coverage    82.3%   80.4%   -2.0%     
========================================
  Files         834     834             
  Lines       35377   35377             
  Branches      748     748             
========================================
- Hits        29148   28455    -693     
- Misses       6039    6744    +705     
+ Partials      190     178     -12     
Flag Coverage Δ
integrationtests ?
unittests 80.4% <0.0%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...simcore_service_webserver/computation_subscribe.py 27.0% <0.0%> (-66.0%) ⬇️
...k/src/simcore_sdk/node_ports_common/filemanager.py 27.9% <0.0%> (-55.2%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/events.py 49.1% <0.0%> (-47.6%) ⬇️
...ules/dynamic_sidecar/docker_service_specs/proxy.py 53.8% <0.0%> (-46.2%) ⬇️
...src/simcore_sdk/node_ports_common/file_io_utils.py 38.7% <0.0%> (-45.0%) ⬇️
.../simcore_service_webserver/computation_settings.py 55.5% <0.0%> (-44.5%) ⬇️
...sdk/src/simcore_sdk/node_ports_common/dbmanager.py 42.4% <0.0%> (-43.9%) ⬇️
...s/dynamic_sidecar/docker_service_specs/settings.py 41.5% <0.0%> (-39.5%) ⬇️
...tor_v2/modules/dynamic_sidecar/scheduler/_utils.py 64.3% <0.0%> (-29.8%) ⬇️
...ore_service_director_v2/api/routes/computations.py 63.9% <0.0%> (-29.5%) ⬇️
... and 37 more

Copy link
Member

@pcrespov pcrespov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you need to rebase --onto last PR here right?

@sanderegg sanderegg force-pushed the maintenance/update_rabbit_mq_service branch 3 times, most recently from 336d1ab to 18027f2 Compare November 1, 2022 07:36
@sanderegg sanderegg force-pushed the maintenance/update_rabbit_mq_service branch from 18027f2 to 23e836a Compare November 1, 2022 10:37
@sonarcloud
Copy link

sonarcloud bot commented Nov 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sanderegg sanderegg changed the title ⬆️ Use latest rabbit MQ service (⚠️ devops) ⬆️ Use latest rabbit MQ service Nov 1, 2022
@sanderegg sanderegg merged commit 3f73cdc into ITISFoundation:master Nov 1, 2022
@sanderegg sanderegg deleted the maintenance/update_rabbit_mq_service branch November 1, 2022 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants